From: David Hildenbrand <david@redhat.com>
To: Wei Yang <richardw.yang@linux.intel.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, mhocko@suse.com,
yang.shi@linux.alibaba.com, rientjes@google.com
Subject: Re: [Patch v2 2/4] mm/migrate.c: wrap do_move_pages_to_node() and store_status()
Date: Wed, 29 Jan 2020 10:28:53 +0100 [thread overview]
Message-ID: <68d4f7fb-2f37-2b11-dd0f-2e059415daf2@redhat.com> (raw)
In-Reply-To: <20200129003812.GC12835@richard>
On 29.01.20 01:38, Wei Yang wrote:
> On Tue, Jan 28, 2020 at 11:14:55AM +0100, David Hildenbrand wrote:
>> On 22.01.20 02:16, Wei Yang wrote:
>>> Usually do_move_pages_to_node() and store_status() is a pair. There are
>>> three places call this pair of functions with almost the same form.
>>
>> I'd suggest
>>
>> "
>> Usually, do_move_pages_to_node() and store_status() are used in
>> combination. We have three similar call sites.
>>
>> Let's provide a wrapper for both function calls -
>> move_pages_and_store_status - to make the calling code easier to
>> maintain and fix (as noted by Yang Shi, the return value handling of
>> do_move_pages_to_node() has a flaw).
>> "
>
> Looks good.
>
>>
>>>
>>> This patch just wrap it to make it friendly to audience and also
>>> consolidate the move and store action into one place. Also mentioned by
>>> Yang Shi, the handling of do_move_pages_to_node()'s return value is not
>>> proper. Now we can fix it in one place.
>>>
>>> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
>>> Acked-by: Michal Hocko <mhocko@suse.com>
>>> ---
>>> mm/migrate.c | 30 +++++++++++++++++++-----------
>>> 1 file changed, 19 insertions(+), 11 deletions(-)
>>>
>>> diff --git a/mm/migrate.c b/mm/migrate.c
>>> index 4c2a21856717..a4d3bd6475e1 100644
>>> --- a/mm/migrate.c
>>> +++ b/mm/migrate.c
>>> @@ -1583,6 +1583,19 @@ static int add_page_for_migration(struct mm_struct *mm, unsigned long addr,
>>> return err;
>>> }
>>>
>>> +static int move_pages_and_store_status(struct mm_struct *mm, int node,
>>> + struct list_head *pagelist, int __user *status,
>>> + int start, int nr)
>>
>> nit: indentation
>>
>
> You mean indent like this?
>
> static int move_pages_and_store_status(struct mm_struct *mm, int node,
> struct list_head *pagelist,
> int __user *status,
>
> This would be along list and I am afraid this is not the only valid code
> style?
Yes, that's what I meant. Documentation/process/coding-style.rst doesn't
mention any specific way, but this is the most commonly used one.
Indentation in this file mostly sticks to something like this as well,
but yeah, it's often a mess and not consistent.
That's why I note it whenever I see it, to make it eventually more
consistent (and only make it a nit) :)
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2020-01-29 9:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 1:16 [Patch v2 0/4] cleanup on do_pages_move() Wei Yang
2020-01-22 1:16 ` [Patch v2 1/4] mm/migrate.c: not necessary to check start and i Wei Yang
2020-01-28 10:04 ` David Hildenbrand
2020-01-29 0:32 ` Wei Yang
2020-01-22 1:16 ` [Patch v2 2/4] mm/migrate.c: wrap do_move_pages_to_node() and store_status() Wei Yang
2020-01-28 10:14 ` David Hildenbrand
2020-01-29 0:38 ` Wei Yang
2020-01-29 9:28 ` David Hildenbrand [this message]
2020-01-29 22:00 ` Wei Yang
2020-01-22 1:16 ` [Patch v2 3/4] mm/migrate.c: check pagelist in move_pages_and_store_status() Wei Yang
2020-01-28 10:21 ` David Hildenbrand
2020-01-29 0:46 ` Wei Yang
2020-01-29 9:36 ` David Hildenbrand
2020-01-22 1:16 ` [Patch v2 4/4] mm/migrate.c: handle same node and add failure in the same way Wei Yang
2020-01-29 10:13 ` David Hildenbrand
2020-01-29 22:07 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68d4f7fb-2f37-2b11-dd0f-2e059415daf2@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=richardw.yang@linux.intel.com \
--cc=rientjes@google.com \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).