linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: John Garry <john.garry@huawei.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	rafael@kernel.org, tglx@linutronix.de,
	linux-kernel@vger.kernel.org, dan.carpenter@oracle.com
Subject: Re: [PATCH] Driver core: platform: Add extra error check in devm_platform_get_irqs_affinity()
Date: Fri, 08 Jan 2021 15:48:24 +0000	[thread overview]
Message-ID: <68e22d9cd4cc631201f06300205bafb6@kernel.org> (raw)
In-Reply-To: <e10af177-583b-636a-be14-6f781baaa61a@huawei.com>

On 2021-01-08 15:43, John Garry wrote:
> On 08/01/2021 15:43, Greg KH wrote:
>> On Mon, Dec 21, 2020 at 10:30:55PM +0800, John Garry wrote:
>>> The current check of nvec < minvec for nvec returned from
>>> platform_irq_count() will not detect a negative error code in nvec.
>>> 
>>> This is because minvec is unsigned, and, as such, nvec is promoted to
>>> unsigned in that check, which will make it a huge number (if it 
>>> contained
>>> -EPROBE_DEFER).
>>> 
>>> In practice, an error should not occur in nvec for the only in-tree
>>> user, but add a check anyway.
>>> 
>>> Fixes: e15f2fa959f2 ("driver core: platform: Add 
>>> devm_platform_get_irqs_affinity()")
>>> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>>> Signed-off-by: John Garry <john.garry@huawei.com>
>>> ---
>>> I hope that this can go through either irqchip or driver/core trees, 
>>> thanks!
>> 
>> I'll take it, thanks.
>> 
> 
> Hi Greg,
> 
> I think that Marc already has taken it:
> 
> https://lore.kernel.org/lkml/X%2Fh9vy%2F1h0E1hyN0@kroah.com/T/#m95ef1736dbbd801cd85a4144c8f13c2afe33bc2c
> 
> I hope it doesn't cause hassle.

I was about to send tglx a pull request.

Greg, let me know if you want me to drop it.

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...

  reply	other threads:[~2021-01-08 15:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-21 14:30 John Garry
2020-12-22  8:12 ` [irqchip: irq/irqchip-next] driver " irqchip-bot for John Garry
2021-01-08 15:43 ` [PATCH] Driver " Greg KH
2021-01-08 15:43   ` John Garry
2021-01-08 15:48     ` Marc Zyngier [this message]
2021-01-08 16:06       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=68e22d9cd4cc631201f06300205bafb6@kernel.org \
    --to=maz@kernel.org \
    --cc=dan.carpenter@oracle.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=john.garry@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=tglx@linutronix.de \
    --subject='Re: [PATCH] Driver core: platform: Add extra error check in devm_platform_get_irqs_affinity()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).