From: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
To: "vkoul@kernel.org" <vkoul@kernel.org>,
"lars@metafoo.de" <lars@metafoo.de>
Cc: "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"alencar.fmce@imbel.gov.br" <alencar.fmce@imbel.gov.br>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dmaengine: axi-dmac: simple device_config operation implemented
Date: Wed, 16 Oct 2019 10:41:41 +0000 [thread overview]
Message-ID: <68e30adcd61677659092ae9a157a12b639a6641d.camel@analog.com> (raw)
In-Reply-To: <20191016050841.GA2654@vkoul-mobl>
On Wed, 2019-10-16 at 10:38 +0530, Vinod Koul wrote:
> [External]
>
> On 15-10-19, 23:06, Lars-Peter Clausen wrote:
>
> > > > This DMA controller is a bit special.
> > > > It gets synthesized in FPGA, so the configuration is fixed and
> > > > cannot be
> > > > changed at runtime. Maybe later we would allow/implement this
> > > > functionality, but this is a question for my HDL colleagues.
> > > >
> > > > Two things are done (in this order):
> > > > 1. For some paramters, axi_dmac_parse_chan_dt() is used to
> > > > determine things
> > > > from device-tree; as it's an FPGA core, things are synthesized once
> > > > and
> > > > cannot change (yet)
> > > > 2. For other parameters, the axi_dmac_detect_caps() is used to
> > > > guess some
> > > > of them at probe time, by doing some reg reads/writes
> > >
> > > So the question for you hw folks is how would a controller work with
> > > multiple slave devices, do they need to synthesize it everytime?
> > >
> > > Rather than that why cant they make the peripheral addresses
> > > programmable so that you dont need updating fpga everytime!
> >
> > The DMA has a direct connection to the peripheral and the peripheral
> > data port is not connected to the general purpose memory interconnect.
> > So you can't write to it by an MMIO address and there is no
> > address
> > that needs to be configured. For an FPGA based design this is quite a
> > good solution in terms of resource usage, performance and simplicity. A
> > direct connection requires less resources than connection it to the
> > central memory interconnect, while at the same time having lower
> > latency
> > and not eating up any additional bandwidth on the central memory
> > connect.
>
> thanks for explanation!
also many thanks [from my side] for the explanations :)
>
> > So slave config in this case is a noop and all it can do is verify that
> > the requested configuration matches the available configuration.
>
> okay so noop it is!
>
prev parent reply other threads:[~2019-10-16 10:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 14:54 [PATCH] dmaengine: axi-dmac: simple device_config operation implemented Alexandru Ardelean
2019-10-14 7:01 ` Vinod Koul
2019-10-15 7:05 ` Ardelean, Alexandru
2019-10-15 10:43 ` Vinod Koul
2019-10-15 21:06 ` Lars-Peter Clausen
2019-10-16 5:08 ` Vinod Koul
2019-10-16 10:41 ` Ardelean, Alexandru [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68e30adcd61677659092ae9a157a12b639a6641d.camel@analog.com \
--to=alexandru.ardelean@analog.com \
--cc=alencar.fmce@imbel.gov.br \
--cc=dmaengine@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).