linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
To: Lino Sanfilippo <l.sanfilippo@kunbus.com>,
	Bagas Sanjaya <bagasdotme@gmail.com>,
	Jarkko Sakkinen <jarkko@kernel.org>,
	Sasha Levin <sashal@kernel.org>, Peter Huewe <peterhuewe@gmx.de>,
	Jason Gunthorpe <jgg@ziepe.ca>
Cc: Linux Kernel Integrity <linux-integrity@vger.kernel.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	Linux Regressions <regressions@lists.linux.dev>,
	Lukas Wunner <lukas@wunner.de>,
	"Philipp Rosenberger" <p.rosenberger@kunbus.com>
Subject: Re: New kernel warning after updating from LTS 5.15.110 to 5.15.112 (and 5.15.113)
Date: Wed, 7 Jun 2023 03:23:05 +0000	[thread overview]
Message-ID: <68e7cee4-4136-3940-2007-55aa094ff790@alliedtelesis.co.nz> (raw)
In-Reply-To: <f905141c-1f8e-aec8-470c-19d476e567a3@kunbus.com>

Hi Lino,

On 7/06/23 13:43, Lino Sanfilippo wrote:
> Hi Bagas, hi Chris
>
> On 06.06.23 04:00, Bagas Sanjaya wrote:
>
>> On Tue, Jun 06, 2023 at 01:41:01AM +0000, Chris Packham wrote:
>>> Bisecting between v5.15.110 and v5.15.112 points to
>>>
>>> 51162b05a44cb5d98fb0ae2519a860910a47fd4b is the first bad commit
>> Thanks for the bisection.
>>
>> Lino, it looks like this regression is caused by (backported) commit of yours.
>> Would you like to take a look on it?
>>
> Before commit 51162b05a44c interrupt activation has failed since the concerning register was accessed
> without holding the required locality.
>
> Now with the commit applied the activation is successful and the interrupt handler is called as soon
> as an interrupt fires. However the handler runs in interrupt context while the register accesses
> are done via SPI which involves the SPI bus_lock_mutex. Calling the (sleepable) SPI functions in
> interrupt context results in the observed warning.
>
> To fix this additionally upstream commit 0c7e66e5fd69 ("tpm, tpm_tis: Request threaded interrupt handler") is
> required, since it ensures that the handler runs in process context.
>
> Note that even with this commit interrupts will eventually be disabled since the test for interrupts
> still fails (for the test to succeed at least upstream commit e644b2f498d2 "tpm, tpm_tis: Enable interrupt test"
> would be required).
>
> Chris, could you test again with commit 0c7e66e5fd69 additionally applied and confirm that the warning is gone?

Yes with 0c7e66e5fd69 cherry-picked on top the warning goes away. Adding 
e644b2f498d2 doesn't seem to change anything (still reports that 
interrupts aren't working) but that's the same as the latest mainline on 
this hardware.

  reply	other threads:[~2023-06-07  3:23 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-28 23:42 New kernel warning after updating from LTS 5.15.110 to 5.15.112 (and 5.15.113) Chris Packham
2023-05-29  2:04 ` Bagas Sanjaya
2023-05-29  2:37   ` Chris Packham
2023-06-02  4:10     ` Bagas Sanjaya
2023-06-02  4:19       ` Chris Packham
2023-06-06  1:41         ` Chris Packham
2023-06-06  2:00           ` Bagas Sanjaya
2023-06-06  6:45             ` Greg KH
2023-06-07 15:47               ` Lino Sanfilippo
2023-06-07 17:49                 ` Greg KH
2023-06-20 12:41                   ` Linux regression tracking #update (Thorsten Leemhuis)
2023-08-31  9:18                     ` Linux regression tracking #update (Thorsten Leemhuis)
2023-06-07  1:43             ` Lino Sanfilippo
2023-06-07  3:23               ` Chris Packham [this message]
2023-06-07 15:01                 ` Lino Sanfilippo
2023-06-06  9:39 ` Jarkko Sakkinen
2023-06-06 21:04   ` Chris Packham
2023-06-07 16:15     ` Jarkko Sakkinen
     [not found]       ` <CT7DAF9JJ4KD.37K8GDWP7GKG1@suppilovahvero>
2023-06-08 20:39         ` Chris Packham
2023-06-09  6:20           ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=68e7cee4-4136-3940-2007-55aa094ff790@alliedtelesis.co.nz \
    --to=chris.packham@alliedtelesis.co.nz \
    --cc=bagasdotme@gmail.com \
    --cc=jarkko@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=l.sanfilippo@kunbus.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=p.rosenberger@kunbus.com \
    --cc=peterhuewe@gmx.de \
    --cc=regressions@lists.linux.dev \
    --cc=sashal@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).