From: Richard Guy Briggs <rgb@redhat.com>
To: Linux-Audit Mailing List <linux-audit@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
io-uring@vger.kernel.org
Cc: Paul Moore <paul@paul-moore.com>,
Eric Paris <eparis@parisplace.org>,
Steve Grubb <sgrubb@redhat.com>,
Richard Guy Briggs <rgb@redhat.com>, Stefan Roesch <shr@fb.com>,
Christian Brauner <brauner@kernel.org>,
Jens Axboe <axboe@kernel.dk>,
Pavel Begunkov <asml.silence@gmail.com>
Subject: [PATCH v1 1/2] io_uring,audit: audit IORING_OP_FADVISE but not IORING_OP_MADVISE
Date: Fri, 27 Jan 2023 12:23:45 -0500 [thread overview]
Message-ID: <68eb0c2dd50bca1af91203669f7f1f8312331f38.1674682056.git.rgb@redhat.com> (raw)
In-Reply-To: <cover.1674682056.git.rgb@redhat.com>
Since FADVISE can truncate files and MADVISE operates on memory, reverse
the audit_skip tags.
Fixes: 5bd2182d58e9 ("audit,io_uring,io-wq: add some basic audit support to io_uring")
Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
---
io_uring/opdef.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/io_uring/opdef.c b/io_uring/opdef.c
index 3aa0d65c50e3..a2bf53b4a38a 100644
--- a/io_uring/opdef.c
+++ b/io_uring/opdef.c
@@ -306,12 +306,12 @@ const struct io_op_def io_op_defs[] = {
},
[IORING_OP_FADVISE] = {
.needs_file = 1,
- .audit_skip = 1,
.name = "FADVISE",
.prep = io_fadvise_prep,
.issue = io_fadvise,
},
[IORING_OP_MADVISE] = {
+ .audit_skip = 1,
.name = "MADVISE",
.prep = io_madvise_prep,
.issue = io_madvise,
--
2.27.0
next prev parent reply other threads:[~2023-01-27 17:25 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 17:23 [PATCH v1 0/2] two suggested iouring op audit updates Richard Guy Briggs
2023-01-27 17:23 ` Richard Guy Briggs [this message]
2023-01-27 22:35 ` [PATCH v1 1/2] io_uring,audit: audit IORING_OP_FADVISE but not IORING_OP_MADVISE Paul Moore
2023-01-27 22:45 ` Jens Axboe
2023-01-27 22:57 ` Paul Moore
2023-01-28 16:48 ` Steve Grubb
2023-01-27 23:02 ` Richard Guy Briggs
2023-01-27 23:03 ` Jens Axboe
2023-01-27 23:08 ` Richard Guy Briggs
2023-01-27 22:55 ` Richard Guy Briggs
2023-01-27 23:05 ` Paul Moore
2023-01-27 17:23 ` [PATCH v1 2/2] io_uring,audit: do not log IORING_OP_*GETXATTR Richard Guy Briggs
2023-01-27 22:43 ` Paul Moore
2023-01-27 23:01 ` Richard Guy Briggs
2023-01-27 23:05 ` Jens Axboe
2023-01-28 0:07 ` Paul Moore
2023-01-28 0:06 ` Paul Moore
2023-01-28 0:19 ` Richard Guy Briggs
2023-01-28 17:26 ` Steve Grubb
2023-01-29 23:37 ` Paul Moore
2023-01-27 17:40 ` [PATCH v1 0/2] two suggested iouring op audit updates Jens Axboe
2023-01-27 19:42 ` Paul Moore
2023-01-27 19:43 ` Jens Axboe
2023-01-27 22:38 ` Paul Moore
2023-01-27 22:46 ` Jens Axboe
2023-01-27 22:53 ` Paul Moore
2023-01-27 23:02 ` Jens Axboe
2023-01-27 23:07 ` Richard Guy Briggs
2023-01-27 23:08 ` Paul Moore
2023-01-27 23:10 ` Jens Axboe
2023-01-28 16:47 ` Steve Grubb
2023-01-28 17:03 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68eb0c2dd50bca1af91203669f7f1f8312331f38.1674682056.git.rgb@redhat.com \
--to=rgb@redhat.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=eparis@parisplace.org \
--cc=io-uring@vger.kernel.org \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=sgrubb@redhat.com \
--cc=shr@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).