From: Jonathan Cameron <jic23@kernel.org>
To: Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Kevin Tsai <capellamicro@gmail.com>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH 1/1] iio: light: Added CM36672 Proximity Sensor Driver.
Date: Sun, 29 May 2016 17:23:37 +0100 [thread overview]
Message-ID: <68f15180-cba4-8afe-1237-be47ae3a7955@kernel.org> (raw)
In-Reply-To: <alpine.DEB.2.02.1605291021570.25960@pmeerw.net>
On 29/05/16 09:55, Peter Meerwald-Stadler wrote:
> On Sat, 28 May 2016, Kevin Tsai wrote:
>
>> Added Vishay Capella CM36672 Proximity Sensor IIO driver. Support both
>> ACPI and Device Tree.
>
> comments below
>
>> Signed-off-by: Kevin Tsai <capellamicro@gmail.com>
>> ---
<snip>
>> +#ifdef CONFIG_ACPI
>> +/**
>> + * cm36672_acpi_get_cpm_info() - Get CPM object from ACPI
>> + * @client: pointer of struct i2c_client.
>> + * @obj_name: pointer of ACPI object name.
>> + * @count: maximum size of return array.
>> + * @vals: pointer of array for return elements.
>> + *
>> + * Convert ACPI CPM table to array. Special thanks Srinivas Pandruvada's
>
> thanks for
thanks to (if we are getting picky ;)
>
>> + * help to implement this routine.
>> + *
>> + * Return: -ENODEV for fail. Otherwise is number of elements.
>
> Otherwise the number of elements
>
next prev parent reply other threads:[~2016-05-29 16:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-29 0:42 [PATCH 1/1] iio: light: Added CM36672 Proximity Sensor Driver Kevin Tsai
2016-05-29 8:55 ` Peter Meerwald-Stadler
2016-05-29 16:23 ` Jonathan Cameron [this message]
2016-05-29 16:45 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68f15180-cba4-8afe-1237-be47ae3a7955@kernel.org \
--to=jic23@kernel.org \
--cc=capellamicro@gmail.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).