From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25391C48BDF for ; Tue, 15 Jun 2021 07:01:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0741E61417 for ; Tue, 15 Jun 2021 07:01:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230212AbhFOHDP (ORCPT ); Tue, 15 Jun 2021 03:03:15 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:28958 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229488AbhFOHDP (ORCPT ); Tue, 15 Jun 2021 03:03:15 -0400 Received: from localhost (mailhub3.si.c-s.fr [192.168.12.233]) by localhost (Postfix) with ESMTP id 4G3zkG2nzhzB9VX; Tue, 15 Jun 2021 09:01:10 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vOWfko6GyBBp; Tue, 15 Jun 2021 09:01:10 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 4G3zkG1sbQz9t3p; Tue, 15 Jun 2021 09:01:10 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 073EF8B7A2; Tue, 15 Jun 2021 09:01:05 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id Vmwdfs1dKPwR; Tue, 15 Jun 2021 09:01:04 +0200 (CEST) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 8C5758B7A0; Tue, 15 Jun 2021 09:01:04 +0200 (CEST) Subject: Re: [PATCH 7/7] powerpc/signal: Use unsafe_copy_siginfo_to_user() To: Christoph Hellwig Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <8b4b640746523f5efb1c9a9fd97465bac4f00cae.1623739212.git.christophe.leroy@csgroup.eu> From: Christophe Leroy Message-ID: <68f4251c-2803-67b8-e8df-1a977ec368ba@csgroup.eu> Date: Tue, 15 Jun 2021 09:00:58 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 15/06/2021 à 08:55, Christoph Hellwig a écrit : >> @@ -836,14 +830,19 @@ int handle_rt_signal32(struct ksignal *ksig, sigset_t *oldset, >> asm("dcbst %y0; sync; icbi %y0; sync" :: "Z" (mctx->mc_pad[0])); >> } >> unsafe_put_sigset_t(&frame->uc.uc_sigmask, oldset, failed); >> +#ifndef CONFIG_COMPAT >> + unsafe_copy_siginfo_to_user(&frame->info, &ksig->info, failed); >> +#endif >> >> /* create a stack frame for the caller of the handler */ >> unsafe_put_user(regs->gpr[1], newsp, failed); >> >> user_access_end(); >> >> - if (copy_siginfo_to_user(&frame->info, &ksig->info)) >> +#ifdef CONFIG_COMPAT >> + if (copy_siginfo_to_user32(&frame->info, &ksig->info)) >> goto badframe; >> +#endif > > Shouldn't the compat case be handled the same way? > It would be best, but it is not that easy to convert. So for the time being it is left aside, anyway compat is for compatibility, so performance doesn't matter so much.