* [PATCH] staging: vt665X: remove unused CONFIG_PATH
@ 2021-07-29 9:58 Greg Kroah-Hartman
2021-07-29 14:51 ` Randy Dunlap
0 siblings, 1 reply; 2+ messages in thread
From: Greg Kroah-Hartman @ 2021-07-29 9:58 UTC (permalink / raw)
To: linux-staging
Cc: forest, linux-kernel, Greg Kroah-Hartman, Joe Perches, Randy Dunlap
The vt6655 and vt6656 drivers have an unused CONFIG_PATH define floating
around in the code, but it is never used. Remove it as drivers should
never be reading from config files anyway, even if these were valid
files.
Reported-by: Joe Perches <joe@perches.com>
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/staging/vt6655/device_cfg.h | 3 ---
drivers/staging/vt6656/device.h | 2 --
2 files changed, 5 deletions(-)
diff --git a/drivers/staging/vt6655/device_cfg.h b/drivers/staging/vt6655/device_cfg.h
index db0304f6e21c..2d647a3619ba 100644
--- a/drivers/staging/vt6655/device_cfg.h
+++ b/drivers/staging/vt6655/device_cfg.h
@@ -38,9 +38,6 @@
#include <linux/fs.h>
#include <linux/fcntl.h>
-#ifndef CONFIG_PATH
-#define CONFIG_PATH "/etc/vntconfiguration.dat"
-#endif
#define PKT_BUF_SZ 2390
diff --git a/drivers/staging/vt6656/device.h b/drivers/staging/vt6656/device.h
index 947530fefe94..2c93a2e66c8a 100644
--- a/drivers/staging/vt6656/device.h
+++ b/drivers/staging/vt6656/device.h
@@ -77,8 +77,6 @@
#define FIRMWARE_NAME "vntwusb.fw"
#define FIRMWARE_CHUNK_SIZE 0x400
-#define CONFIG_PATH "/etc/vntconfiguration.dat"
-
#define MAX_UINTS 8
#define OPTION_DEFAULT { [0 ... MAX_UINTS - 1] = -1}
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: vt665X: remove unused CONFIG_PATH
2021-07-29 9:58 [PATCH] staging: vt665X: remove unused CONFIG_PATH Greg Kroah-Hartman
@ 2021-07-29 14:51 ` Randy Dunlap
0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2021-07-29 14:51 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-staging; +Cc: forest, linux-kernel, Joe Perches
On 7/29/21 2:58 AM, Greg Kroah-Hartman wrote:
> The vt6655 and vt6656 drivers have an unused CONFIG_PATH define floating
> around in the code, but it is never used. Remove it as drivers should
> never be reading from config files anyway, even if these were valid
> files.
>
> Reported-by: Joe Perches <joe@perches.com>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> drivers/staging/vt6655/device_cfg.h | 3 ---
> drivers/staging/vt6656/device.h | 2 --
> 2 files changed, 5 deletions(-)
>
> diff --git a/drivers/staging/vt6655/device_cfg.h b/drivers/staging/vt6655/device_cfg.h
> index db0304f6e21c..2d647a3619ba 100644
> --- a/drivers/staging/vt6655/device_cfg.h
> +++ b/drivers/staging/vt6655/device_cfg.h
> @@ -38,9 +38,6 @@
>
> #include <linux/fs.h>
> #include <linux/fcntl.h>
> -#ifndef CONFIG_PATH
> -#define CONFIG_PATH "/etc/vntconfiguration.dat"
> -#endif
>
> #define PKT_BUF_SZ 2390
>
> diff --git a/drivers/staging/vt6656/device.h b/drivers/staging/vt6656/device.h
> index 947530fefe94..2c93a2e66c8a 100644
> --- a/drivers/staging/vt6656/device.h
> +++ b/drivers/staging/vt6656/device.h
> @@ -77,8 +77,6 @@
> #define FIRMWARE_NAME "vntwusb.fw"
> #define FIRMWARE_CHUNK_SIZE 0x400
>
> -#define CONFIG_PATH "/etc/vntconfiguration.dat"
> -
> #define MAX_UINTS 8
> #define OPTION_DEFAULT { [0 ... MAX_UINTS - 1] = -1}
>
>
--
~Randy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-29 14:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-29 9:58 [PATCH] staging: vt665X: remove unused CONFIG_PATH Greg Kroah-Hartman
2021-07-29 14:51 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).