From: Pavel Skripkin <paskripkin@gmail.com>
To: Jaehee Park <jhpark1013@gmail.com>, Larry.Finger@lwfinger.net
Cc: phil@philpotter.co.uk, gregkh@linuxfoundation.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
outreachy@lists.linux.dev,
Alison Schofield <alison.schofield@intel.com>
Subject: Re: [PATCH v2 3/6] staging: r8188eu: remove 'added by' author comments
Date: Sun, 17 Apr 2022 23:23:03 +0300 [thread overview]
Message-ID: <6925e230-b816-ea9a-067f-60cefecd8af7@gmail.com> (raw)
In-Reply-To: <c0eaa7cbc61d89967d81ef864c1a791f4adb1978.1649990500.git.jhpark1013@gmail.com>
Hi Jaehee,
On 4/15/22 05:48, Jaehee Park wrote:
> Author comments "Added by Albert" and "Added by Annie" are sprinkled
> through the file. These comments are not useful and can be removed.
>
> Reviewed-by: Pavel Skripkin <paskripkin@gmail.com>
I don't remember giving that tag, but now I am OK with it, since patch
looks good
Please, don't put random Reviewed-by tags in your commit message, since
it's not how Reviewed-by tags work
> Suggested-by: Alison Schofield <alison.schofield@intel.com>
> Signed-off-by: Jaehee Park <jhpark1013@gmail.com>
With regards,
Pavel Skripkin
next prev parent reply other threads:[~2022-04-17 20:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 2:48 [PATCH v2 0/6] staging: r8188eu: fix warnings reported by checkpatch Jaehee Park
2022-04-15 2:48 ` [PATCH v2 1/6] staging: r8188eu: remove unused member free_bss_buf Jaehee Park
2022-04-15 4:29 ` Fabio M. De Francesco
2022-04-17 20:14 ` Jaehee Park
2022-04-17 20:16 ` Pavel Skripkin
2022-04-17 20:42 ` Jaehee Park
2022-04-17 21:13 ` Fabio M. De Francesco
2022-04-17 22:01 ` Fabio M. De Francesco
2022-04-18 4:49 ` Jaehee Park
2022-04-15 2:48 ` [PATCH v2 2/6] staging: r8188eu: remove spaces before tabs Jaehee Park
2022-04-15 2:48 ` [PATCH v2 3/6] staging: r8188eu: remove 'added by' author comments Jaehee Park
2022-04-17 20:23 ` Pavel Skripkin [this message]
2022-04-17 20:49 ` Jaehee Park
2022-04-15 2:48 ` [PATCH v2 4/6] staging: r8188eu: place constants on the right side of tests Jaehee Park
2022-04-15 4:57 ` Fabio M. De Francesco
2022-04-15 2:48 ` [PATCH v2 5/6] staging: r8188eu: replace spaces with tabs Jaehee Park
2022-04-15 2:48 ` [PATCH v2 6/6] staging: r8188eu: correct typo in comments Jaehee Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6925e230-b816-ea9a-067f-60cefecd8af7@gmail.com \
--to=paskripkin@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=alison.schofield@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jhpark1013@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).