From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Juergen Gross <jgross@suse.com>,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Cc: Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH 2/2] xen/xenbus: let xenbus_map_ring_valloc() return errno values only
Date: Mon, 11 May 2020 14:32:05 -0400 [thread overview]
Message-ID: <692e23f8-1eb7-4fb2-7375-e85cb27dfab0@oracle.com> (raw)
In-Reply-To: <20200511073151.19043-3-jgross@suse.com>
[-- Attachment #1: Type: text/plain, Size: 668 bytes --]
On 5/11/20 3:31 AM, Juergen Gross wrote:
> Today xenbus_map_ring_valloc() can return either a negative errno
> value (-ENOMEM or -EINVAL) or a grant status value. This is a mess as
> e.g -ENOMEM and GNTST_eagain have the same numeric value.
>
> Fix that by turning all grant mapping errors into -ENOENT. This is
> no problem as all callers of xenbus_map_ring_valloc() only use the
> return value to print an error message, and in case of mapping errors
> the grant status value has already been printed by __xenbus_map_ring()
> before.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
[-- Attachment #2: pEpkey.asc --]
[-- Type: application/pgp-keys, Size: 5075 bytes --]
prev parent reply other threads:[~2020-05-11 18:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 7:31 [PATCH 0/2] xen/xenbus: some cleanups Juergen Gross
2020-05-11 7:31 ` [PATCH 1/2] xen/xenbus: avoid large structs and arrays on the stack Juergen Gross
2020-05-11 18:01 ` Boris Ostrovsky
2020-05-12 9:13 ` Jürgen Groß
2020-05-11 7:31 ` [PATCH 2/2] xen/xenbus: let xenbus_map_ring_valloc() return errno values only Juergen Gross
2020-05-11 18:32 ` Boris Ostrovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=692e23f8-1eb7-4fb2-7375-e85cb27dfab0@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).