From: Luca Weiss <luca@z3ntu.xyz>
To: Jack Matthews <jm5112356@gmail.com>
Cc: jm5112356@gmail.com, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ARM: dts: qcom: pm8226: add node for RTC
Date: Wed, 30 Mar 2022 21:31:59 +0200 [thread overview]
Message-ID: <6933014.lOV4Wx5bFT@g550jk> (raw)
In-Reply-To: <20220209165742.652890-1-jm5112356@gmail.com>
On Mittwoch, 9. Februar 2022 17:57:41 CEST Jack Matthews wrote:
> Add a node for PM8226's real time clock.
>
> Signed-off-by: Jack Matthews <jm5112356@gmail.com>
Reviewed-by: Luca Weiss <luca@z3ntu.xyz>
Also on lg-lenok at least "allow-set-time;" seems to allow writing to the RTC.
As I'm quite unsure of the reasoning of it normally being read-only and the
implementation details behind what might restrict this I don't think we can
safely add this to all pm8226.
Regards
Luca
> ---
> arch/arm/boot/dts/qcom-pm8226.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom-pm8226.dtsi
> b/arch/arm/boot/dts/qcom-pm8226.dtsi index 872724490a5d..8ee628ce88a9
> 100644
> --- a/arch/arm/boot/dts/qcom-pm8226.dtsi
> +++ b/arch/arm/boot/dts/qcom-pm8226.dtsi
> @@ -73,6 +73,13 @@ adc-chan@f {
> };
> };
>
> + rtc@6000 {
> + compatible = "qcom,pm8941-rtc";
> + reg = <0x6000>, <0x6100>;
> + reg-names = "rtc", "alarm";
> + interrupts = <0x0 0x61 0x1
IRQ_TYPE_EDGE_RISING>;
> + };
> +
> pm8226_mpps: mpps@a000 {
> compatible = "qcom,pm8226-mpp", "qcom,spmi-
mpp";
> reg = <0xa000>;
prev parent reply other threads:[~2022-03-30 19:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 5:29 [PATCH] ARM: dts: qcom: pm8226: add node for RTC Jack Matthews
2022-02-09 8:00 ` Luca Weiss
2022-02-09 16:57 ` [PATCH v2] " Jack Matthews
2022-03-30 19:31 ` Luca Weiss [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6933014.lOV4Wx5bFT@g550jk \
--to=luca@z3ntu.xyz \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jm5112356@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).