From: John Garry <john.garry@huawei.com>
To: Bart Van Assche <bvanassche@acm.org>,
Pradeep P V K <ppvk@codeaurora.org>, <axboe@kernel.dk>,
<linux-block@vger.kernel.org>
Cc: <stummala@codeaurora.org>, <linux-kernel@vger.kernel.org>,
Ming Lei <ming.lei@redhat.com>
Subject: Re: [PATCH V1] block: Fix use-after-free while iterating over requests
Date: Thu, 26 Nov 2020 16:49:41 +0000 [thread overview]
Message-ID: <693ea723-aa9e-1166-8a19-a7787f724969@huawei.com> (raw)
In-Reply-To: <c94fcada-7f6d-a1e3-4c88-d225af1a676e@acm.org>
On 26/11/2020 16:27, Bart Van Assche wrote:
> On 11/26/20 7:02 AM, Pradeep P V K wrote:
>> Observes below crash while accessing (use-after-free) request queue
>> member of struct request.
>>
>> 191.784789: <2> Unable to handle kernel paging request at virtual
>> address ffffff81429a4440
>> ...
>> 191.786174: <2> CPU: 3 PID: 213 Comm: kworker/3:1H Tainted: G S
>> O 5.4.61-qgki-debug-ge45de39 #1
>> ...
>> 191.786226: <2> Workqueue: kblockd blk_mq_timeout_work
>> 191.786242: <2> pstate: 20c00005 (nzCv daif +PAN +UAO)
>> 191.786261: <2> pc : bt_for_each+0x114/0x1a4
>> 191.786274: <2> lr : bt_for_each+0xe0/0x1a4
>> ...
>> 191.786494: <2> Call trace:
>> 191.786507: <2> bt_for_each+0x114/0x1a4
>> 191.786519: <2> blk_mq_queue_tag_busy_iter+0x60/0xd4
>> 191.786532: <2> blk_mq_timeout_work+0x54/0xe8
>> 191.786549: <2> process_one_work+0x2cc/0x568
>> 191.786562: <2> worker_thread+0x28c/0x518
>> 191.786577: <2> kthread+0x160/0x170
>> 191.786594: <2> ret_from_fork+0x10/0x18
>> 191.786615: <2> Code: 0b080148 f9404929 f8685921 b4fffe01 (f9400028)
>> 191.786630: <2> ---[ end trace 0f1f51d79ab3f955 ]---
>> 191.786643: <2> Kernel panic - not syncing: Fatal exception
>>
>> Fix this by updating the freed request with NULL.
>> This could avoid accessing the already free request from other
>> contexts while iterating over the requests.
>>
>> Signed-off-by: Pradeep P V K <ppvk@codeaurora.org>
>> ---
>> block/blk-mq.c | 1 +
>> block/blk-mq.h | 1 +
>> 2 files changed, 2 insertions(+)
>>
>> diff --git a/block/blk-mq.c b/block/blk-mq.c
>> index 55bcee5..9996cb1 100644
>> --- a/block/blk-mq.c
>> +++ b/block/blk-mq.c
>> @@ -492,6 +492,7 @@ static void __blk_mq_free_request(struct request *rq)
>>
>> blk_crypto_free_request(rq);
>> blk_pm_mark_last_busy(rq);
>> + hctx->tags->rqs[rq->tag] = NULL;
>> rq->mq_hctx = NULL;
>> if (rq->tag != BLK_MQ_NO_TAG)
>> blk_mq_put_tag(hctx->tags, ctx, rq->tag);
>> diff --git a/block/blk-mq.h b/block/blk-mq.h
>> index a52703c..8747bf1 100644
>> --- a/block/blk-mq.h
>> +++ b/block/blk-mq.h
>> @@ -224,6 +224,7 @@ static inline int __blk_mq_active_requests(struct blk_mq_hw_ctx *hctx)
>> static inline void __blk_mq_put_driver_tag(struct blk_mq_hw_ctx *hctx,
>> struct request *rq)
>> {
>> + hctx->tags->rqs[rq->tag] = NULL;
>> blk_mq_put_tag(hctx->tags, rq->mq_ctx, rq->tag);
>> rq->tag = BLK_MQ_NO_TAG;
>
> Is this perhaps a block driver bug instead of a block layer core bug? If
> this would be a block layer core bug, it would have been reported before.
Isn't this the same issue which as been reported many times:
https://lore.kernel.org/linux-block/20200820180335.3109216-1-ming.lei@redhat.com/
https://lore.kernel.org/linux-block/8376443a-ec1b-0cef-8244-ed584b96fa96@huawei.com/
But I never saw a crash, just kasan report.
Thanks,
John
next prev parent reply other threads:[~2020-11-26 16:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 15:02 [PATCH V1] block: Fix use-after-free while iterating over requests Pradeep P V K
2020-11-26 16:27 ` Bart Van Assche
2020-11-26 16:49 ` John Garry [this message]
2020-11-30 7:04 ` Hannes Reinecke
2020-11-30 14:54 ` John Garry
2020-11-30 14:58 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=693ea723-aa9e-1166-8a19-a7787f724969@huawei.com \
--to=john.garry@huawei.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=ppvk@codeaurora.org \
--cc=stummala@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).