linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Baoyou Xie <baoyou.xie@linaro.org>
Cc: liviu.dudau@arm.com, brian.starkey@arm.com, malidp@foss.arm.com,
	airlied@linux.ie, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn,
	han.fei@zte.com.cn, tang.qiang007@zte.com.cn
Subject: Re: [PATCH] drm/arm: mark symbols static where possible
Date: Mon, 24 Oct 2016 12:18:37 +0200	[thread overview]
Message-ID: <6967038.koRMV7E4Wg@wuerfel> (raw)
In-Reply-To: <1477127581-1095-1-git-send-email-baoyou.xie@linaro.org>

On Saturday, October 22, 2016 5:13:01 PM CEST Baoyou Xie wrote:
> We get 2 warnings when building kernel with W=1:
> drivers/gpu/drm/arm/malidp_planes.c:49:25: warning: no previous prototype for 'malidp_duplicate_plane_state' [-Wmissing-prototypes]
> drivers/gpu/drm/arm/malidp_planes.c:66:6: warning: no previous prototype for 'malidp_destroy_plane_state' [-Wmissing-prototypes]
> 
> In fact, both functions are only used in the file in which they are
> declared and don't need a declaration, but can be made static.
> So this patch marks these functions with 'static'.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---
...
> @@ -63,7 +64,7 @@ struct drm_plane_state *malidp_duplicate_plane_state(struct drm_plane *plane)
>  	return &state->base;
>  }
>  
> -void malidp_destroy_plane_state(struct drm_plane *plane,
> +static void malidp_destroy_plane_state(struct drm_plane *plane,
>  				struct drm_plane_state *state)
>  {
>  	struct malidp_plane_state *m_state = to_malidp_plane_state(state);
> 

The change looks correct, but I notice that the two lines of the
declaration are no longer aligned.

The file follows the normal style of aligning the argument list
in the second line to line up with the opening '(', so please keep
it that way.

	Arnd

  reply	other threads:[~2016-10-24 10:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-22  9:13 [PATCH] drm/arm: mark symbols static where possible Baoyou Xie
2016-10-24 10:18 ` Arnd Bergmann [this message]
2016-10-24 17:50   ` liviu.dudau
  -- strict thread matches above, loose matches on Subject: below --
2016-10-22  9:07 Baoyou Xie
2016-09-06  7:23 Baoyou Xie
2016-09-06  8:07 ` liviu.dudau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6967038.koRMV7E4Wg@wuerfel \
    --to=arnd@arndb.de \
    --cc=airlied@linux.ie \
    --cc=baoyou.xie@linaro.org \
    --cc=brian.starkey@arm.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=han.fei@zte.com.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liviu.dudau@arm.com \
    --cc=malidp@foss.arm.com \
    --cc=tang.qiang007@zte.com.cn \
    --cc=xie.baoyou@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).