From: "Heiko Stübner" <heiko@sntech.de>
To: Jagan Teki <jagan@amarulasolutions.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Suniel Mahesh <sunil@amarulasolutions.com>,
Michael Trimarchi <michael@amarulasolutions.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
devicetree <devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-amarula <linux-amarula@amarulasolutions.com>
Subject: Re: [PATCH v2 3/6] dt-bindings: arm: rockchip: Add ROCKPi 4B binding
Date: Thu, 23 Jul 2020 10:27:14 +0200 [thread overview]
Message-ID: <6968987.cG2su2sgyb@diego> (raw)
In-Reply-To: <CAMty3ZDk28-wg_=wdf_Ps-5RaHK1T-+h0Jn43aK5ReWAz+GTGw@mail.gmail.com>
Am Donnerstag, 23. Juli 2020, 08:34:12 CEST schrieb Jagan Teki:
> Hi Heiko,
>
> On Thu, Jul 23, 2020 at 4:43 AM Heiko Stuebner <heiko@sntech.de> wrote:
> >
> > Hi Jagan,
> >
> > Am Mittwoch, 22. Juli 2020, 21:09:46 CEST schrieb Jagan Teki:
> > > Add dt-bindings for ROCKPi 4B which is similar to 4A with
> > > additional AP6256 Wifi/BT, PoE.
> > >
> > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > > ---
> > > Changes for v2:
> > > - new patch
> > >
> > > Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++++
> > > 1 file changed, 6 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> > > index 36057c9e4b83..7250adb43d24 100644
> > > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> > > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> > > @@ -448,6 +448,12 @@ properties:
> > > - const: radxa,rockpi4a
> > > - const: rockchip,rk3399
> > >
> > > + - description: Radxa ROCK Pi 4B
> > > + items:
> > > + - const: radxa,rockpi4
> > > + - const: radxa,rockpi4b
> > > + - const: rockchip,rk3399
> > > +
> >
> > Please do all RockPi4 variants into one entry, so we want something like:
> >
> > - description: Radxa ROCK Pi 4
>
> What if the description has something like below.
>
> - description: Radxa ROCK Pi 4A/B/C
That's also ok :-)
next prev parent reply other threads:[~2020-07-23 8:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 19:09 [PATCH v2 1/6] dt-bindings: arm: rockchip: Update ROCKPi 4 with 4A binding Jagan Teki
2020-07-22 19:09 ` [PATCH v2 2/6] arm64: dts: rockchip: Mark rock-pi-4 as rock-pi-4a dts Jagan Teki
2020-07-22 19:09 ` [PATCH v2 3/6] dt-bindings: arm: rockchip: Add ROCKPi 4B binding Jagan Teki
2020-07-22 23:13 ` Heiko Stuebner
2020-07-23 6:34 ` Jagan Teki
2020-07-23 8:27 ` Heiko Stübner [this message]
2020-07-22 19:09 ` [PATCH v2 4/6] arm64: dts: rockchip: Add Radxa ROCK Pi 4B support Jagan Teki
2020-07-22 19:09 ` [PATCH v2 5/6] dt-bindings: arm: rockchip: Add ROCKPi 4C binding Jagan Teki
2020-07-22 19:09 ` [PATCH v2 6/6] arm64: dts: rockchip: Add Radxa ROCK Pi 4C support Jagan Teki
2020-07-23 20:22 ` [PATCH v2 1/6] dt-bindings: arm: rockchip: Update ROCKPi 4 with 4A binding Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6968987.cG2su2sgyb@diego \
--to=heiko@sntech.de \
--cc=devicetree@vger.kernel.org \
--cc=jagan@amarulasolutions.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=michael@amarulasolutions.com \
--cc=robh+dt@kernel.org \
--cc=sunil@amarulasolutions.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).