From: Shiyang Ruan <ruansy.fnst@fujitsu.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-xfs@vger.kernel.org>,
<nvdimm@lists.linux.dev>, <linux-mm@kvack.org>,
<linux-fsdevel@vger.kernel.org>, <djwong@kernel.org>,
<dan.j.williams@intel.com>, <david@fromorbit.com>,
<jane.chu@oracle.com>, <rgoldwyn@suse.de>,
<viro@zeniv.linux.org.uk>, <willy@infradead.org>,
<naoya.horiguchi@nec.com>, <linmiaohe@huawei.com>
Subject: Re: [PATCH v11 06/07] xfs: support CoW in fsdax mode
Date: Tue, 10 May 2022 18:06:03 +0800 [thread overview]
Message-ID: <696970ff-6a35-831a-da82-bba7975628c7@fujitsu.com> (raw)
In-Reply-To: <Ynn8BnZclNoEuzvv@infradead.org>
在 2022/5/10 13:45, Christoph Hellwig 写道:
>> +#ifdef CONFIG_FS_DAX
>> +int
>> +xfs_dax_fault(
>> + struct vm_fault *vmf,
>> + enum page_entry_size pe_size,
>> + bool write_fault,
>> + pfn_t *pfn)
>> +{
>> + return dax_iomap_fault(vmf, pe_size, pfn, NULL,
>> + (write_fault && !vmf->cow_page) ?
>> + &xfs_dax_write_iomap_ops :
>> + &xfs_read_iomap_ops);
>> +}
>> +#endif
>
> Is there any reason this is in xfs_iomap.c and not xfs_file.c?
Yes, It's better to put it in xfs_file.c since it's the only caller. I
didn't notice it...
--
Thanks,
Ruan.
>
> Otherwise the patch looks good:
>
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2022-05-10 10:06 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-08 14:36 [PATCHSETS] v14 fsdax-rmap + v11 fsdax-reflink Shiyang Ruan
2022-05-08 14:36 ` [PATCH v14 01/07] dax: Introduce holder for dax_device Shiyang Ruan
2022-05-08 14:36 ` [PATCH v14 02/07] mm: factor helpers for memory_failure_dev_pagemap Shiyang Ruan
2022-05-08 14:36 ` [PATCH v14 03/07] pagemap,pmem: Introduce ->memory_failure() Shiyang Ruan
2022-05-08 14:36 ` [PATCH v14 04/07] fsdax: Introduce dax_lock_mapping_entry() Shiyang Ruan
2022-05-08 14:36 ` [PATCH v14 05/07] mm: Introduce mf_dax_kill_procs() for fsdax case Shiyang Ruan
2022-05-08 14:36 ` [PATCH v14 06/07] xfs: Implement ->notify_failure() for XFS Shiyang Ruan
2022-05-08 14:36 ` [PATCH v14 07/07] fsdax: set a CoW flag when associate reflink mappings Shiyang Ruan
2022-05-08 14:36 ` [PATCH v11 01/07] fsdax: Output address in dax_iomap_pfn() and rename it Shiyang Ruan
2022-05-08 14:36 ` [PATCH v11 02/07] fsdax: Introduce dax_iomap_cow_copy() Shiyang Ruan
2022-05-08 14:36 ` [PATCH v11 03/07] fsdax: Replace mmap entry in case of CoW Shiyang Ruan
2022-05-08 14:36 ` [PATCH v11 04/07] fsdax: Add dax_iomap_cow_copy() for dax zero Shiyang Ruan
2022-05-08 14:36 ` [PATCH v11 05/07] fsdax: Dedup file range to use a compare function Shiyang Ruan
2022-05-08 14:36 ` [PATCH v11 06/07] xfs: support CoW in fsdax mode Shiyang Ruan
2022-05-10 5:45 ` Christoph Hellwig
2022-05-10 10:06 ` Shiyang Ruan [this message]
2022-05-11 2:25 ` [PATCH v11.1 " Shiyang Ruan
2022-05-08 14:36 ` [PATCH v11 07/07] xfs: Add dax dedupe support Shiyang Ruan
2022-05-10 9:32 ` [PATCHSETS] v14 fsdax-rmap + v11 fsdax-reflink Christoph Hellwig
2022-05-11 0:03 ` Darrick J. Wong
2022-05-11 1:48 ` Dave Chinner
2022-05-11 1:55 ` Dan Williams
2022-05-11 2:19 ` Dave Chinner
2022-05-11 2:28 ` Andrew Morton
2022-05-11 2:43 ` Darrick J. Wong
2022-05-11 5:24 ` Andrew Morton
2022-05-11 6:21 ` Dave Chinner
2022-05-11 15:19 ` Darrick J. Wong
2022-05-11 15:46 ` Dan Williams
2022-05-12 12:27 ` Shiyang Ruan
2022-06-02 9:42 ` Shiyang Ruan
2022-06-02 17:18 ` Darrick J. Wong
2022-06-02 17:47 ` Andrew Morton
2022-05-11 4:20 ` Dan Williams
2022-05-11 4:34 ` Darrick J. Wong
2022-06-02 18:56 ` Andrew Morton
2022-06-03 1:07 ` Shiyang Ruan
2022-06-03 1:36 ` Shiyang Ruan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=696970ff-6a35-831a-da82-bba7975628c7@fujitsu.com \
--to=ruansy.fnst@fujitsu.com \
--cc=dan.j.williams@intel.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=jane.chu@oracle.com \
--cc=linmiaohe@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=naoya.horiguchi@nec.com \
--cc=nvdimm@lists.linux.dev \
--cc=rgoldwyn@suse.de \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).