linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Frank Rowand <frowand.list@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Pantelis Antoniou <pantelis.antoniou@konsulko.com>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Masahiro Yamada <masahiroy@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	David Gibson <david@gibson.dropbear.id.au>,
	Bill Mills <bill.mills@linaro.org>,
	anmar.oueja@linaro.org
Subject: [PATCH V5 5/5] of: unittest: Statically apply overlays using fdtoverlay
Date: Wed, 20 Jan 2021 12:36:47 +0530	[thread overview]
Message-ID: <696c137461be8ec4395c733c559c269bb4ad586e.1611124778.git.viresh.kumar@linaro.org> (raw)
In-Reply-To: <cover.1611124778.git.viresh.kumar@linaro.org>

Now that fdtoverlay is part of the kernel build, start using it to test
the unitest overlays we have by applying them statically.

Some unittest overlays deliberately contain errors that unittest checks
for. These overlays will cause fdtoverlay to fail, and are thus not
included in the static_test.dtb.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 drivers/of/unittest-data/Makefile | 50 +++++++++++++++++++++++++++++++
 1 file changed, 50 insertions(+)

diff --git a/drivers/of/unittest-data/Makefile b/drivers/of/unittest-data/Makefile
index 009f4045c8e4..ece7dfd5cafa 100644
--- a/drivers/of/unittest-data/Makefile
+++ b/drivers/of/unittest-data/Makefile
@@ -38,3 +38,53 @@ DTC_FLAGS_testcases += -@
 
 # suppress warnings about intentional errors
 DTC_FLAGS_testcases += -Wno-interrupts_property
+
+# Apply overlays statically with fdtoverlay.  This is a build time test that
+# the overlays can be applied successfully by fdtoverlay.  This does not
+# guarantee that the overlays can be applied successfully at run time by
+# unittest, but it provides a bit of build time test coverage for those
+# who do not execute unittest.
+#
+# The overlays are applied on top of testcases.dtb to create static_test.dtb
+# If fdtoverlay detects an error than the kernel build will fail.
+# static_test.dtb is not consumed by unittest.
+#
+# Some unittest overlays deliberately contain errors that unittest checks for.
+# These overlays will cause fdtoverlay to fail, and are thus not included
+# in the static test:
+#			overlay.dtb \
+#			overlay_bad_add_dup_node.dtb \
+#			overlay_bad_add_dup_prop.dtb \
+#			overlay_bad_phandle.dtb \
+#			overlay_bad_symbol.dtb \
+#			overlay_base.dtb \
+
+apply_static_overlay := overlay_0.dtb \
+			overlay_1.dtb \
+			overlay_2.dtb \
+			overlay_3.dtb \
+			overlay_4.dtb \
+			overlay_5.dtb \
+			overlay_6.dtb \
+			overlay_7.dtb \
+			overlay_8.dtb \
+			overlay_9.dtb \
+			overlay_10.dtb \
+			overlay_11.dtb \
+			overlay_12.dtb \
+			overlay_13.dtb \
+			overlay_15.dtb \
+			overlay_gpio_01.dtb \
+			overlay_gpio_02a.dtb \
+			overlay_gpio_02b.dtb \
+			overlay_gpio_03.dtb \
+			overlay_gpio_04a.dtb \
+			overlay_gpio_04b.dtb
+
+quiet_cmd_fdtoverlay = FDTOVERLAY $@
+      cmd_fdtoverlay = $(objtree)/scripts/dtc/fdtoverlay -o $@ -i $^
+
+$(obj)/static_test.dtb: $(obj)/testcases.dtb $(addprefix $(obj)/,$(apply_static_overlay))
+	$(call if_changed,fdtoverlay)
+
+always-$(CONFIG_OF_OVERLAY) += static_test.dtb
-- 
2.25.0.rc1.19.g042ed3e048af


  parent reply	other threads:[~2021-01-20  7:09 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20  7:06 [PATCH V5 0/5] dt: build overlays Viresh Kumar
2021-01-20  7:06 ` [PATCH V5 1/5] scripts: dtc: Fetch fdtoverlay.c from external DTC project Viresh Kumar
2021-01-20  7:06 ` [PATCH V5 2/5] scripts: dtc: Build fdtoverlay tool Viresh Kumar
2021-01-20  7:06 ` [PATCH V5 3/5] scripts: dtc: Remove the unused fdtdump.c file Viresh Kumar
2021-01-21  0:44   ` David Gibson
2021-01-21  4:17     ` Viresh Kumar
2021-01-21  6:26       ` David Gibson
2021-01-21 14:18         ` Rob Herring
2021-01-20  7:06 ` [PATCH V5 4/5] kbuild: Add support to build overlays (%.dtbo) Viresh Kumar
2021-01-20  8:58   ` Masahiro Yamada
2021-01-20  9:55     ` Viresh Kumar
2021-01-20 11:04       ` Masahiro Yamada
2021-01-20 11:27         ` Viresh Kumar
2021-01-21  0:49   ` David Gibson
2021-01-21  4:13     ` Viresh Kumar
2021-01-21  5:40       ` Frank Rowand
2021-01-21  6:25       ` David Gibson
2021-01-20  7:06 ` Viresh Kumar [this message]
2021-01-21  0:51   ` [PATCH V5 5/5] of: unittest: Statically apply overlays using fdtoverlay David Gibson
2021-01-21  5:14     ` Frank Rowand
2021-01-21  5:34       ` Viresh Kumar
2021-01-21  5:45         ` Frank Rowand
2021-01-21  5:50           ` Viresh Kumar
2021-01-21  6:36             ` David Gibson
2021-01-21  6:34         ` David Gibson
2021-01-21  6:57           ` Viresh Kumar
2021-01-21 23:39             ` David Gibson
2021-01-22  3:10               ` Viresh Kumar
2021-01-22  4:27                 ` David Gibson
2021-01-21  5:34       ` Frank Rowand
2021-01-21  5:43         ` Viresh Kumar
2021-01-21  5:55           ` Frank Rowand
2021-01-21  5:58             ` Viresh Kumar
2021-01-21  7:04               ` Frank Rowand
2021-01-21 23:41                 ` David Gibson
2021-01-21  6:37             ` David Gibson
2021-01-20 15:43 ` [PATCH V5 0/5] dt: build overlays Rob Herring
2021-01-21  4:14   ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=696c137461be8ec4395c733c559c269bb4ad586e.1611124778.git.viresh.kumar@linaro.org \
    --to=viresh.kumar@linaro.org \
    --cc=anmar.oueja@linaro.org \
    --cc=bill.mills@linaro.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=pantelis.antoniou@konsulko.com \
    --cc=robh+dt@kernel.org \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).