From: Heiko Stuebner <heiko@sntech.de>
To: Brian Norris <briannorris@chromium.org>
Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Caesar Wang <wxt@rock-chips.com>,
Doug Anderson <dianders@chromium.org>,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Stephen Barber <smbarber@chromium.org>,
linux-arm-kernel@lists.infradead.org,
Chris Zhong <zyw@rock-chips.com>
Subject: Re: [PATCH v2 4/6] arm64: dts: rockchip: add Gru/Kevin DTS
Date: Tue, 28 Feb 2017 23:00:25 +0100 [thread overview]
Message-ID: <6978416.eyJmBK6ozI@phil> (raw)
In-Reply-To: <20170210010521.78872-5-briannorris@chromium.org>
Hi Brian,
Am Donnerstag, 9. Februar 2017, 17:05:19 CET schrieb Brian Norris:
> Kevin is part of a family of boards called Gru. As best as possible, the
> properties shared by the Gru family are placed in rk3399-gru.dtsi, while
> Kevin-specific bits are in rk3399-gru-kevin.dts. This does not add full
> support for the base Gru board.
>
short summary of what we just talked about, and some more minor things I found
[...]
> + /* pp3300 children */
drop that. I may not have caught all of them, but you get the idea ;-)
> + pp3300_wifi_bt: pp3300-wifi-bt {
> + compatible = "regulator-fixed";
> + regulator-name = "pp3300_wifi_bt";
> + /* NOTE: wlan_module_pd_l pinctrl in pp1800_pcie */
> +
> + enable-active-high;
> +
> + /* NOTE: this GPIO also used in pp1800_pcie */
does the gpio subsystem like this double usage?
> + gpio = <&gpio0 4 GPIO_ACTIVE_HIGH>;
> +
> + vin-supply = <&pp3300>;
> + };
> +
> + /* pp5000 aliases; these are always on for AP so just use alias */
drop that
> +
> + /* EC turns on w/ usb_a_en */
> + pp5000_usb_a_vbus: pp5000 {
> + };
> +
> + /* END REGULATORS */
drop that
> +
> + io-domains {
&io_domains instead
> + compatible = "rockchip,rk3399-io-voltage-domain";
> + rockchip,grf = <&grf>;
> +
> + bt656-supply = <&pp1800_ap_io>; /* APIO2_VDD; 2a 2b */
> + audio-supply = <&pp1800_audio>; /* APIO5_VDD; 3d 4a */
> + sdmmc-supply = <&ppvar_sd_card_io>; /* SDMMC0_VDD; 4b */
> + gpio1830-supply = <&pp3000_ap>; /* APIO4_VDD; 4c 4d */
> + };
> + pmu-io-domains {
&pmu_io_domains instead
> + compatible = "rockchip,rk3399-pmu-io-voltage-domain";
> + rockchip,grf = <&pmugrf>;
> +
> + pmu1830-supply = <&pp1800_pmu>; /* PMUIO2_VDD */
> + };
> +#include "common/cros-ec-keyboard.dtsi"
> +#include "common/cros-ec-sbs.dtsi"
please try the arm include symlinks instead
> +
> +/* PINCTRL: always below everything else */
> +
drop this
> +
> +/* DON'T PUT ANYTHING BELOW HERE. PUT IT ABOVE PINCTRL */
> +/* DON'T PUT ANYTHING BELOW HERE. PUT IT ABOVE PINCTRL */
> +/* DON'T PUT ANYTHING BELOW HERE. PUT IT ABOVE PINCTRL */
> +
drop these
Heiko
next prev parent reply other threads:[~2017-02-28 23:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-10 1:05 [PATCH v2 0/6] arm64: dts: rockchip: support Google Kevin Brian Norris
2017-02-10 1:05 ` [PATCH v2 1/6] arm64: dts: Add symlinks for cros-ec-keyboard and cros-ec-sbs Brian Norris
2017-02-21 23:47 ` Olof Johansson
2017-02-27 18:20 ` Heiko Stuebner
2017-03-20 23:07 ` Brian Norris
2017-04-19 12:54 ` Olof Johansson
2017-04-19 13:25 ` Heiko Stuebner
2017-04-19 13:31 ` Olof Johansson
2017-02-10 1:05 ` [PATCH v2 2/6] arm64: dts: rockchip: support dwc3 USB for rk3399 Brian Norris
2017-02-10 22:01 ` Heiko Stuebner
2017-02-10 1:05 ` [PATCH v2 3/6] dt-bindings: Document rk3399 Gru/Kevin Brian Norris
2017-02-16 2:12 ` Rob Herring
2017-02-10 1:05 ` [PATCH v2 4/6] arm64: dts: rockchip: add Gru/Kevin DTS Brian Norris
2017-02-28 22:00 ` Heiko Stuebner [this message]
2017-02-28 22:54 ` Doug Anderson
2017-02-10 1:05 ` [PATCH v2 5/6] arm64: dts: rockchip: describe Gru/Kevin OPPs + CPU regulators Brian Norris
2017-02-10 1:05 ` [PATCH v2 6/6] arm64: dts: rockchip: sort rk3399 by unit address Brian Norris
2017-02-10 21:39 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6978416.eyJmBK6ozI@phil \
--to=heiko@sntech.de \
--cc=briannorris@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=smbarber@chromium.org \
--cc=wxt@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).