From: Marcel Holtmann <marcel@holtmann.org>
To: Hilda Wu <hildawu@realtek.com>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
Bluetooth Kernel Mailing List <linux-bluetooth@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
apusaka@chromium.org, tientzu@chromium.org, max.chou@realtek.com,
alex_lu@realsil.com.cn, kidman@realtek.com
Subject: Re: [PATCH v3 2/2] Bluetooth: hci_h5: Add flag for keep power during suspend/resume
Date: Fri, 23 Apr 2021 08:54:57 +0200 [thread overview]
Message-ID: <698B6653-F1C9-4250-86A3-1780CC1D5DAD@holtmann.org> (raw)
In-Reply-To: <20210423035229.27513-3-hildawu@realtek.com>
Hi Hilda,
> RTL8822C and RTL8852A devices support BT wakeup Host. Add a flag
> for these specific devices did not power off during suspend and resume.
> By this change, if the Host support that received BT device signal then
> it can wake Host up.
>
> Signed-off-by: hildawu <hildawu@realtek.com>
> ---
> Changed in v3:
> - Reworked to use UART flag, refer to Maintainer's suggestion.
> - Split into two patches for different purpose.
>
> Changes in v2:
> - Add the missing struct member
> - Modify title length
> ---
> ---
> drivers/bluetooth/hci_h5.c | 34 ++++++++++++++++++++++++----------
> drivers/bluetooth/hci_ldisc.c | 3 ++-
> drivers/bluetooth/hci_uart.h | 1 +
> 3 files changed, 27 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/bluetooth/hci_h5.c b/drivers/bluetooth/hci_h5.c
> index 27e96681d583..9cacc4cdc928 100644
> --- a/drivers/bluetooth/hci_h5.c
> +++ b/drivers/bluetooth/hci_h5.c
> @@ -911,6 +911,15 @@ static int h5_btrtl_setup(struct h5 *h5)
> */
> set_bit(HCI_QUIRK_SIMULTANEOUS_DISCOVERY, &h5->hu->hdev->quirks);
>
> + switch (btrtl_dev->project_id) {
> + case CHIP_ID_8822C:
> + case CHIP_ID_8852A:
> + set_bit(HCI_UART_WAKEUP_ENABLE, &h5->hu->hdev_flags);
> + break;
> + default:
> + break;
> + }
> +
> out_free:
> btrtl_free(btrtl_dev);
>
> @@ -945,8 +954,11 @@ static void h5_btrtl_close(struct h5 *h5)
> static int h5_btrtl_suspend(struct h5 *h5)
> {
> serdev_device_set_flow_control(h5->hu->serdev, false);
> - gpiod_set_value_cansleep(h5->device_wake_gpio, 0);
> - gpiod_set_value_cansleep(h5->enable_gpio, 0);
> +
> + if (!test_bit(HCI_UART_WAKEUP_ENABLE, &h5->hu->hdev_flags)) {
> + gpiod_set_value_cansleep(h5->device_wake_gpio, 0);
> + gpiod_set_value_cansleep(h5->enable_gpio, 0);
> + }
> return 0;
> }
>
> @@ -972,17 +984,19 @@ static void h5_btrtl_reprobe_worker(struct work_struct *work)
>
> static int h5_btrtl_resume(struct h5 *h5)
> {
> - struct h5_btrtl_reprobe *reprobe;
> + if (!test_bit(HCI_UART_WAKEUP_ENABLE, &h5->hu->hdev_flags)) {
> + struct h5_btrtl_reprobe *reprobe;
>
> - reprobe = kzalloc(sizeof(*reprobe), GFP_KERNEL);
> - if (!reprobe)
> - return -ENOMEM;
> + reprobe = kzalloc(sizeof(*reprobe), GFP_KERNEL);
> + if (!reprobe)
> + return -ENOMEM;
>
> - __module_get(THIS_MODULE);
> + __module_get(THIS_MODULE);
>
> - INIT_WORK(&reprobe->work, h5_btrtl_reprobe_worker);
> - reprobe->dev = get_device(&h5->hu->serdev->dev);
> - queue_work(system_long_wq, &reprobe->work);
> + INIT_WORK(&reprobe->work, h5_btrtl_reprobe_worker);
> + reprobe->dev = get_device(&h5->hu->serdev->dev);
> + queue_work(system_long_wq, &reprobe->work);
> + }
> return 0;
> }
>
> diff --git a/drivers/bluetooth/hci_ldisc.c b/drivers/bluetooth/hci_ldisc.c
> index 637c5b8c2aa1..3a1038e9dc6a 100644
> --- a/drivers/bluetooth/hci_ldisc.c
> +++ b/drivers/bluetooth/hci_ldisc.c
> @@ -719,7 +719,8 @@ static int hci_uart_set_flags(struct hci_uart *hu, unsigned long flags)
> BIT(HCI_UART_CREATE_AMP) |
> BIT(HCI_UART_INIT_PENDING) |
> BIT(HCI_UART_EXT_CONFIG) |
> - BIT(HCI_UART_VND_DETECT);
> + BIT(HCI_UART_VND_DETECT) |
> + BIT(HCI_UART_WAKEUP_ENABLE);
>
> if (flags & ~valid_flags)
> return -EINVAL;
> diff --git a/drivers/bluetooth/hci_uart.h b/drivers/bluetooth/hci_uart.h
> index 4e039d7a16f8..25f5e5c7544c 100644
> --- a/drivers/bluetooth/hci_uart.h
> +++ b/drivers/bluetooth/hci_uart.h
> @@ -41,6 +41,7 @@
> #define HCI_UART_INIT_PENDING 3
> #define HCI_UART_EXT_CONFIG 4
> #define HCI_UART_VND_DETECT 5
> +#define HCI_UART_WAKEUP_ENABLE 6
don’t use these flags since they are an ioctl API.
Regards
Marcel
prev parent reply other threads:[~2021-04-23 6:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 3:52 [PATCH v3 0/2] Bluetooth hci_h5 btrtl Add flag for keep power in suspend/resume hildawu
2021-04-23 3:52 ` [PATCH v3 1/2] Bluetooth: btrtl: Adjust the position of strcut definition hildawu
2021-04-23 6:56 ` Marcel Holtmann
2021-04-23 3:52 ` [PATCH v3 2/2] Bluetooth: hci_h5: Add flag for keep power during suspend/resume hildawu
2021-04-23 6:54 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=698B6653-F1C9-4250-86A3-1780CC1D5DAD@holtmann.org \
--to=marcel@holtmann.org \
--cc=alex_lu@realsil.com.cn \
--cc=apusaka@chromium.org \
--cc=hildawu@realtek.com \
--cc=johan.hedberg@gmail.com \
--cc=kidman@realtek.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=max.chou@realtek.com \
--cc=tientzu@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).