From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757401AbaCED5r (ORCPT ); Tue, 4 Mar 2014 22:57:47 -0500 Received: from [207.46.163.139] ([207.46.163.139]:47873 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1756680AbaCED5p convert rfc822-to-8bit (ORCPT ); Tue, 4 Mar 2014 22:57:45 -0500 From: "Li.Xiubo@freescale.com" To: Mark Brown , Lars-Peter Clausen CC: "lgirdwood@gmail.com" , "Fabio.Estevam@freescale.com" , "moinejf@free.fr" , "alsa-devel@alsa-project.org" , "kuninori.morimoto.gx@renesas.com" , "tiwai@suse.de" , "s.hauer@pengutronix.de" , "timur@tabi.org" , "linux-kernel@vger.kernel.org" , "denis@eukrea.com" , "guangyu.chen@freescale.com" , "mpa@pengutronix.de" , "shawn.guo@linaro.org" Subject: RE: [alsa-devel] [PATCH 01/10] ASoC: core: Add snd_soc_dai_set_tdm_slot_xlate(). Thread-Topic: [alsa-devel] [PATCH 01/10] ASoC: core: Add snd_soc_dai_set_tdm_slot_xlate(). Thread-Index: AQHPMrCgZUeIw1X2K0GrJD0FMlCJVprMPHAAgAWnPICAAADBIA== Date: Wed, 5 Mar 2014 03:55:50 +0000 Message-ID: <6991b4aaf2a34f8180b24f7a2ae8355a@BY2PR03MB505.namprd03.prod.outlook.com> References: <1393387175-15539-1-git-send-email-Li.Xiubo@freescale.com> <1393387175-15539-2-git-send-email-Li.Xiubo@freescale.com> <5311DE70.7000901@metafoo.de> <20140305033935.GY13126@sirena.org.uk> In-Reply-To: <20140305033935.GY13126@sirena.org.uk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [123.151.195.49] x-forefront-prvs: 01415BB535 x-forefront-antispam-report: SFV:NSPM;SFS:(10009001)(6009001)(428001)(24454002)(199002)(189002)(164054003)(51704005)(83322001)(86362001)(94946001)(59766001)(77982001)(46102001)(33646001)(85852003)(81686001)(65816001)(80022001)(66066001)(93136001)(54356001)(53806001)(51856001)(74502001)(76576001)(94316002)(95416001)(93516002)(47446002)(80976001)(81542001)(76786001)(76796001)(63696002)(92566001)(85306002)(31966008)(79102001)(69226001)(81342001)(74366001)(74706001)(74316001)(56816005)(47976001)(50986001)(90146001)(81816001)(4396001)(83072002)(49866001)(54316002)(76482001)(87936001)(2656002)(95666003)(47736001)(87266001)(74876001)(24736002);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR03MB254;H:BY2PR03MB505.namprd03.prod.outlook.com;CLIP:123.151.195.49;FPR:ACF3FC33.A4DAAF13.53DCBDDB.48FAE1B8.20263;MLV:sfv;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: freescale.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Subject: Re: [alsa-devel] [PATCH 01/10] ASoC: core: Add > snd_soc_dai_set_tdm_slot_xlate(). > > On Sat, Mar 01, 2014 at 02:19:44PM +0100, Lars-Peter Clausen wrote: > > > I'm not quite sure I fully understand what this patch is trying to > > solve. It adds a variant snd_soc_dai_set_tdm_slot() that instead of > > taking a rx and tx mask calculates the masks based on the number of > > slots? In that case I don't really see how the xlate in the name > > relates to that. xlate is something you'd typically expect in a > > devicetree context. Maybe one should be called > > snd_soc_dai_set_tdm_slot() and the other > > snd_soc_dai_set_tdm_slot_and_masks()? > > > But another question is do we really need this? I don't see the > > problem that is solved by this patchset. > > My understanding is that the patch set aims to provide a way of using > the TDM features of drivers from DT, providing a standardised format for > expressing the TDM setup in the DT. I've not looked at the actual code > yet though. @Lars, Sorry for late, many mails had been discard by my outlook, including the Last one. @Mark, @Lars, This adds the function of snd_soc_dai_set_tdm_slot_xlate, which is almost One new signature of snd_soc_dai_set_tdm_slot discarding the mask Parameters, which could be generated by itself. And I want to provide one standard method for the drivers who are parsing The TDM information from the DT node. Thanks, -- Best Regards, Xiubo