From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Martin Kaiser <martin@kaiser.cx>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Michael Straube <straube.linux@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Martin Kaiser <martin@kaiser.cx>
Subject: Re: [PATCH 1/7] staging: r8188eu: remove haldata's EEPROMVID / PID
Date: Fri, 12 Nov 2021 10:00:59 +0100 [thread overview]
Message-ID: <6997531.xZuqOj027S@localhost.localdomain> (raw)
In-Reply-To: <20211111212644.9011-1-martin@kaiser.cx>
On Thursday, November 11, 2021 10:26:38 PM CET Martin Kaiser wrote:
> They are used only in a (disabled) debug print.
>
> In practice, lsusb can be used to read the actual vid and pid.
Hi Martin,
You seem to have overlooked the usual rules for writing conformant commit
messages :)
Please say "what" you did along with "why" you made the changes.
Here, and in two or three other patches of your series, you forgot to
describe "what" you did. You actually wrote it in the "Subject" lines but, as
you know for sure, commit messages must be self-contained entities.
Also, it would be nice to have a cover letter and have all seven patches in
one thread in response to the above, even if it (AFAIK) is not strictly
required.
Anyway, many thanks for your work.
Regards,
Fabio
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
> drivers/staging/r8188eu/hal/usb_halinit.c | 8 --------
> drivers/staging/r8188eu/include/rtl8188e_hal.h | 2 --
> drivers/staging/r8188eu/include/rtl8188e_spec.h | 2 --
> 3 files changed, 12 deletions(-)
next prev parent reply other threads:[~2021-11-12 9:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 21:26 [PATCH 1/7] staging: r8188eu: remove haldata's EEPROMVID / PID Martin Kaiser
2021-11-11 21:26 ` [PATCH 2/7] staging: r8188eu: remove haldata's EEPROMCustomerID Martin Kaiser
2021-11-11 21:26 ` [PATCH 3/7] staging: r8188eu: remove haldata's EEPROMSubCustomerID Martin Kaiser
2021-11-11 21:26 ` [PATCH 4/7] staging: r8188eu: remove autoload check Martin Kaiser
2021-11-12 9:08 ` Fabio M. De Francesco
2021-11-11 21:26 ` [PATCH 5/7] staging: r8188eu: rf_chip is constant Martin Kaiser
2021-11-11 21:26 ` [PATCH 6/7] staging: r8188eu: merge three small functions Martin Kaiser
2021-11-11 21:26 ` [PATCH 7/7] staging: r8188eu: simplify two boolean assignments Martin Kaiser
2021-11-12 9:00 ` Fabio M. De Francesco [this message]
2021-11-13 16:21 ` [PATCH 1/7] staging: r8188eu: remove haldata's EEPROMVID / PID Martin Kaiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6997531.xZuqOj027S@localhost.localdomain \
--to=fmdefrancesco@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).