From: Keerthy <j-keerthy@ti.com>
To: "Andrew F. Davis" <afd@ti.com>, Sekhar Nori <nsekhar@ti.com>,
Kevin Hilman <khilman@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>
Cc: <linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/5] gpio: davinci: Remove unneeded GPIO macro
Date: Wed, 19 Sep 2018 10:32:31 +0530 [thread overview]
Message-ID: <699a7da7-1a4f-427a-b89e-aa082f77102a@ti.com> (raw)
In-Reply-To: <20180831191326.25106-4-afd@ti.com>
On Saturday 01 September 2018 12:43 AM, Andrew F. Davis wrote:
> This macro does nothing and has only one user, remove it.
Tested for gpio interrupts on k2g and da850-lcdk
Tested-by: Keerthy <j-keerthy@ti.com>
Acked-by: Keerthy <j-keerthy@ti.com>
>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> ---
> arch/arm/mach-davinci/board-neuros-osd2.c | 8 ++++----
> include/linux/platform_data/gpio-davinci.h | 5 -----
> 2 files changed, 4 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm/mach-davinci/board-neuros-osd2.c b/arch/arm/mach-davinci/board-neuros-osd2.c
> index 353f9e5a1454..efdaa27241c5 100644
> --- a/arch/arm/mach-davinci/board-neuros-osd2.c
> +++ b/arch/arm/mach-davinci/board-neuros-osd2.c
> @@ -130,10 +130,10 @@ static struct platform_device davinci_fb_device = {
> };
>
> static const struct gpio_led ntosd2_leds[] = {
> - { .name = "led1_green", .gpio = GPIO(10), },
> - { .name = "led1_red", .gpio = GPIO(11), },
> - { .name = "led2_green", .gpio = GPIO(12), },
> - { .name = "led2_red", .gpio = GPIO(13), },
> + { .name = "led1_green", .gpio = 10, },
> + { .name = "led1_red", .gpio = 11, },
> + { .name = "led2_green", .gpio = 12, },
> + { .name = "led2_red", .gpio = 13, },
> };
>
> static struct gpio_led_platform_data ntosd2_leds_data = {
> diff --git a/include/linux/platform_data/gpio-davinci.h b/include/linux/platform_data/gpio-davinci.h
> index b8e4957e7568..47695b342883 100644
> --- a/include/linux/platform_data/gpio-davinci.h
> +++ b/include/linux/platform_data/gpio-davinci.h
> @@ -45,11 +45,6 @@ struct davinci_gpio_controller {
> int irqs[MAX_INT_PER_BANK];
> };
>
> -/*
> - * basic gpio routines
> - */
> -#define GPIO(X) (X) /* 0 <= X <= (DAVINCI_N_GPIO - 1) */
> -
> /* Convert GPIO signal to GPIO pin number */
> #define GPIO_TO_PIN(bank, gpio) (16 * (bank) + (gpio))
>
>
next prev parent reply other threads:[~2018-09-19 5:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 19:13 [PATCH 1/5] gpio: davinci: Remove unused member of davinci_gpio_controller Andrew F. Davis
2018-08-31 19:13 ` [PATCH 2/5] gpio: davinci: Use dev name for label and automatic base selection Andrew F. Davis
2018-09-03 5:40 ` Keerthy
2018-09-05 10:37 ` Linus Walleij
2018-09-06 14:16 ` Keerthy
2018-09-08 19:41 ` Grygorii Strashko
2018-09-10 2:47 ` Keerthy
2018-09-10 22:05 ` Grygorii Strashko
2018-09-10 7:25 ` Linus Walleij
2018-09-10 7:37 ` Sekhar Nori
2018-09-10 17:03 ` David Lechner
2018-09-18 19:26 ` Linus Walleij
2018-09-19 4:08 ` Keerthy
2018-08-31 19:13 ` [PATCH 3/5] gpio: davinci: Allocate the correct amount of memory for controller Andrew F. Davis
2018-09-19 5:02 ` Keerthy
2018-08-31 19:13 ` [PATCH 4/5] gpio: davinci: Remove unneeded GPIO macro Andrew F. Davis
2018-09-19 5:02 ` Keerthy [this message]
2018-08-31 19:13 ` [PATCH 5/5] gpio: davinci: Move driver local definitions to driver Andrew F. Davis
2018-09-19 5:02 ` Keerthy
2018-09-18 19:24 ` [PATCH 1/5] gpio: davinci: Remove unused member of davinci_gpio_controller Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=699a7da7-1a4f-427a-b89e-aa082f77102a@ti.com \
--to=j-keerthy@ti.com \
--cc=afd@ti.com \
--cc=khilman@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).