From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751627AbdBSRWH (ORCPT ); Sun, 19 Feb 2017 12:22:07 -0500 Received: from mail-eopbgr00069.outbound.protection.outlook.com ([40.107.0.69]:48471 "EHLO EUR02-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751351AbdBSRWE (ORCPT ); Sun, 19 Feb 2017 12:22:04 -0500 From: Majd Dibbiny To: SF Markus Elfring CC: "linux-rdma@vger.kernel.org" , Doug Ledford , Hal Rosenstock , "Leon Romanovsky" , Matan Barak , "Sean Hefty" , Yishai Hadas , LKML , "kernel-janitors@vger.kernel.org" Subject: Re: [PATCH 11/29] IB/mlx4: Use kmalloc_array() in three functions Thread-Topic: [PATCH 11/29] IB/mlx4: Use kmalloc_array() in three functions Thread-Index: AQHSiiry0g9AHjowJkeJlWSRpeK5YaFwkxmA Date: Sun, 19 Feb 2017 17:21:57 +0000 Message-ID: <69F665D3-8CA0-4229-999B-DE2020ECA09E@mellanox.com> References: <1935365a-bd7c-461e-6a84-0c5d3a501fff@users.sourceforge.net> <3002f281-292a-c53e-0b37-d23a3be0d5d7@users.sourceforge.net> In-Reply-To: <3002f281-292a-c53e-0b37-d23a3be0d5d7@users.sourceforge.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=majd@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [46.121.82.152] x-ms-office365-filtering-correlation-id: 1ee3727e-94a5-4a75-26d4-08d458ebce95 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081);SRVR:VI1PR0501MB1933; x-microsoft-exchange-diagnostics: 1;VI1PR0501MB1933;7:74emAhYWcAnW2cGTA3JyAq34VEYtxb2nFm2ipXx1avKgRz0cLKqsTIGBcDfGstS8UqEvj+DoWt3PrUjoX68XyD0EYxyZtfjEL9+IvqqunwdvAopy1kbPmrja1Y2DnaZ262VPpMn4N43Y0g3zKl+oDat7aJxvQm+f1efC6pWtyb9e9WbgTRA0zMZVgIj6hAHHtMbotHf8GHqTYzcqFCCpVJ5A8OrvZJHXAamfO3tgZB8EWfm+m3VnWzsBFetnwSzOEochb5MvIlUrC01p11Tyn1hDWwNeNWi0+A9kbAvNdIS3UNxP1RlItPHA2IS6MHT9Uryd22MgDnaQwZ2aWDph+A== x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(42262312472803); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026)(6041248)(20161123558025)(20161123560025)(20161123555025)(20161123562025)(20161123564025)(6042181)(6072148);SRVR:VI1PR0501MB1933;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0501MB1933; x-forefront-prvs: 02234DBFF6 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(24454002)(199003)(377454003)(189002)(2900100001)(99286003)(68736007)(305945005)(6512007)(6306002)(6116002)(2950100002)(229853002)(102836003)(3846002)(7736002)(38730400002)(54906002)(82746002)(2906002)(77096006)(3280700002)(39060400002)(6506006)(6486002)(6436002)(92566002)(6916009)(4326007)(25786008)(86362001)(122556002)(189998001)(5660300001)(97736004)(50986999)(83716003)(8676002)(966004)(8936002)(36756003)(81166006)(81156014)(110136004)(54356999)(76176999)(6246003)(66066001)(53936002)(106356001)(105586002)(106116001)(33656002)(101416001)(3660700001)(104396002);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0501MB1933;H:DB6PR0501MB2072.eurprd05.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Feb 2017 17:21:57.1811 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB1933 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v1JHMhPB011818 > On Feb 18, 2017, at 11:07 PM, SF Markus Elfring wrote: > > From: Markus Elfring > Date: Sat, 18 Feb 2017 10:32:32 +0100 > > Multiplications for the size determination of memory allocations > indicated that array data structures should be processed. > Thus use the corresponding function "kmalloc_array". > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/infiniband/hw/mlx4/main.c | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) > > diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers/infiniband/hw/mlx4/main.c > index ba6af84cc236..350c9148340e 100644 > --- a/drivers/infiniband/hw/mlx4/main.c > +++ b/drivers/infiniband/hw/mlx4/main.c > @@ -304,7 +304,9 @@ static int mlx4_ib_add_gid(struct ib_device *device, > ctx->refcount++; > } > if (!ret && hw_update) { > - gids = kmalloc(sizeof(*gids) * MLX4_MAX_PORT_GIDS, GFP_ATOMIC); > + gids = kmalloc_array(MLX4_MAX_PORT_GIDS, > + sizeof(*gids), > + GFP_ATOMIC); > if (!gids) { > ret = -ENOMEM; > } else { > @@ -359,7 +361,9 @@ static int mlx4_ib_del_gid(struct ib_device *device, > if (!ret && hw_update) { > int i; > > - gids = kmalloc(sizeof(*gids) * MLX4_MAX_PORT_GIDS, GFP_ATOMIC); > + gids = kmalloc_array(MLX4_MAX_PORT_GIDS, > + sizeof(*gids), > + GFP_ATOMIC); > if (!gids) { > ret = -ENOMEM; > } else { > @@ -2828,9 +2832,9 @@ static void *mlx4_ib_add(struct mlx4_dev *dev) > goto err_counter; > > ibdev->ib_uc_qpns_bitmap = > - kmalloc(BITS_TO_LONGS(ibdev->steer_qpn_count) * > - sizeof(long), > - GFP_KERNEL); > + kmalloc_array(BITS_TO_LONGS(ibdev->steer_qpn_count), > + sizeof(long), > + GFP_KERNEL); > if (!ibdev->ib_uc_qpns_bitmap) > goto err_steer_qp_release; > > -- > 2.11.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Thanks, Reviewed-by: Majd Dibbiny