From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: kernel test robot <yujie.liu@intel.com>, Brent Lu <brent.lu@intel.com>
Cc: ALSA Development Mailing List <alsa-devel@alsa-project.org>,
kbuild-all@lists.01.org, paul@pgazz.com, fazilyildiran@gmail.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Mark Brown <broonie@kernel.org>
Subject: Re: kismet: WARNING: unmet direct dependencies detected for SND_SOC_MAX98357A when selected by SND_SOC_INTEL_SOF_CS42L42_MACH
Date: Wed, 11 May 2022 15:07:34 -0500 [thread overview]
Message-ID: <69a3eaf4-0ad6-ffbf-f5be-d6fdc880276f@linux.intel.com> (raw)
In-Reply-To: <dfae72f1-0ee0-cf22-0fd7-5465209fb8b0@linux.intel.com>
>>>> kismet: WARNING: unmet direct dependencies detected for
>> SND_SOC_MAX98357A when selected by SND_SOC_INTEL_SOF_CS42L42_MACH
>>
>> WARNING: unmet direct dependencies detected for SND_SOC_MAX98357A
>> Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] &&
>> GPIOLIB [=n]
>> Selected by [y]:
>> - SND_SOC_INTEL_SOF_CS42L42_MACH [=y] && SOUND [=y] && !UML && SND
>> [=y] && SND_SOC [=y] && SND_SOC_INTEL_MACH [=y] && (SND_SOC_SOF_HDA_LINK
>> [=y] || SND_SOC_SOF_BAYTRAIL [=n]) && I2C [=y] && ACPI [=y] &&
>> SND_HDA_CODEC_HDMI [=y] && SND_SOC_SOF_HDA_AUDIO_CODEC [=y] &&
>> (MFD_INTEL_LPSS [=y] || COMPILE_TEST [=n])
>
> I can reproduce this, but I question the hard dependency on GPIOLIB in
> the amplifier Kconfig:
>
> max98357a->sdmode = devm_gpiod_get_optional(&pdev->dev,
> "sdmode", GPIOD_OUT_LOW);
>
> If the gpio is optional, max98357a.c should build and compile without
> GPIOLIB, no?
The warning goes away with the patch suggested in
https://github.com/thesofproject/linux/pull/3646
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index b106e55170904..8536773548090 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -986,7 +986,6 @@ config SND_SOC_MAX98095
config SND_SOC_MAX98357A
tristate "Maxim MAX98357A CODEC"
- depends on GPIOLIB
config SND_SOC_MAX98371
tristate
prev parent reply other threads:[~2022-05-11 20:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <202205110550.80rLRw2L-lkp@intel.com>
2022-05-11 3:36 ` kismet: WARNING: unmet direct dependencies detected for SND_SOC_MAX98357A when selected by SND_SOC_INTEL_SOF_CS42L42_MACH kernel test robot
2022-05-11 19:51 ` Pierre-Louis Bossart
2022-05-11 20:07 ` Pierre-Louis Bossart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69a3eaf4-0ad6-ffbf-f5be-d6fdc880276f@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=brent.lu@intel.com \
--cc=broonie@kernel.org \
--cc=fazilyildiran@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@pgazz.com \
--cc=yujie.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).