From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756638AbdJLUMn (ORCPT ); Thu, 12 Oct 2017 16:12:43 -0400 Received: from gate2.alliedtelesis.co.nz ([202.36.163.20]:49207 "EHLO gate2.alliedtelesis.co.nz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756515AbdJLUMj (ORCPT ); Thu, 12 Oct 2017 16:12:39 -0400 From: Chris Packham To: Gregory CLEMENT CC: "linux@roeck-us.net" , "wim@iguana.be" , "devicetree@vger.kernel.org" , "linux-watchdog@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Rob Herring , "Mark Rutland" , Russell King , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH 3/3] ARM: mvebu: dts: connect interrupt for WD on armada-38x Thread-Topic: [PATCH 3/3] ARM: mvebu: dts: connect interrupt for WD on armada-38x Thread-Index: AQHTQ2TDK3/RzlJ0UU6M2pEMR5v0Qg== Date: Thu, 12 Oct 2017 20:12:36 +0000 Message-ID: <69ab72d5008744df9455712c2c821730@svr-chch-ex1.atlnz.lc> References: <20171011022958.31268-1-chris.packham@alliedtelesis.co.nz> <20171011022958.31268-4-chris.packham@alliedtelesis.co.nz> <874lr4bgdh.fsf@free-electrons.com> Accept-Language: en-NZ, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [2001:df5:b000:22:3a2c:4aff:fe70:2b02] Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v9CKCm0M003143 On 13/10/17 03:17, Gregory CLEMENT wrote: > Hi Chris, > > On mer., oct. 11 2017, Chris Packham wrote: > >> The watchdog timer interrupt is available internally on the Armada-38x >> SoCs. Connect it so that we can have the orion_wdt_irq generate debug >> information when a watchdog timeout occurs. > > Given the patch 2, when an interrupt is provided by the dt, then the > behavior of the watchdog changes. So we can't do it for all the > platform. > > As you propose on your cover letter it is better to set it at board > level. > > So instead of this patch you should update the binding documentation > with this new resources. Thanks to this each board developer will be > able to decide to use this feature or not. Agreed. I'll drop this patch in favor of a documentation update in v2. > > Thanks, > > Gregory > >> >> Signed-off-by: Chris Packham >> --- >> arch/arm/boot/dts/armada-38x.dtsi | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi >> index 7ff0811e61db..9ac76c54c9e5 100644 >> --- a/arch/arm/boot/dts/armada-38x.dtsi >> +++ b/arch/arm/boot/dts/armada-38x.dtsi >> @@ -408,6 +408,7 @@ >> reg = <0x20300 0x34>, <0x20704 0x4>, <0x18260 0x4>; >> clocks = <&coreclk 2>, <&refclk>; >> clock-names = "nbclk", "fixed"; >> + interrupts = ; >> }; >> >> cpurst: cpurst@20800 { >> -- >> 2.14.2 >> >