From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: alsa-devel@alsa-project.org, Jonathan Corbet <corbet@lwn.net>,
tiwai@suse.de, gregkh@linuxfoundation.org,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
linux-kernel@vger.kernel.org,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
broonie@kernel.org, srinivas.kandagatla@linaro.org,
jank@cadence.com, slawomir.blauciak@intel.com,
Sanyog Kale <sanyog.r.kale@intel.com>,
Bard liao <yung-chuan.liao@linux.intel.com>,
Rander Wang <rander.wang@linux.intel.com>
Subject: Re: [alsa-devel] [PATCH 2/6] soundwire: stream: update state machine and add state checks
Date: Sat, 11 Jan 2020 05:30:18 -0600 [thread overview]
Message-ID: <69ad48b0-fa3c-904a-4106-5cd9bd18de5c@linux.intel.com> (raw)
In-Reply-To: <a18c668f-4628-0fb9-ffa0-b24cdad1cc8b@linux.intel.com>
On 1/10/20 10:30 AM, Pierre-Louis Bossart wrote:
>
>>> - int sdw_prepare_stream(struct sdw_stream_runtime * stream);
>>> + int sdw_prepare_stream(struct sdw_stream_runtime * stream, bool
>>> resume);
>>
>> so what does the additional argument of resume do..?
>>
>>> diff --git a/drivers/soundwire/stream.c b/drivers/soundwire/stream.c
>>> index 178ae92b8cc1..6aa0b5d370c0 100644
>>> --- a/drivers/soundwire/stream.c
>>> +++ b/drivers/soundwire/stream.c
>>> @@ -1553,8 +1553,18 @@ int sdw_prepare_stream(struct
>>> sdw_stream_runtime *stream)
>>
>> and it is not modified here, so is the doc correct or this..?
>
> the doc is correct and the code is updated in
>
> [PATCH 4/6] soundwire: stream: do not update parameters during
> DISABLED-PREPARED transition
Sorry, wrong answer, my bad. The code block in the documentation is
incorrect.
The Patch 4/6 implements the transition mentioned in the documentation,
but the extra parameter is a left-over from an earlier version. This
case is now handled internally. We did revert to the initial prototype
after finding out that dealing with transitions in the caller is
error-prone.
Will fix in v2, thanks for spotting this.
next prev parent reply other threads:[~2020-01-11 12:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 17:54 [PATCH 0/6] soundwire: stream: fix state machines and transitions Pierre-Louis Bossart
2020-01-08 17:54 ` [PATCH 1/6] soundwire: stream: remove redundant pr_err traces Pierre-Louis Bossart
2020-01-10 7:04 ` Vinod Koul
2020-01-08 17:54 ` [PATCH 2/6] soundwire: stream: update state machine and add state checks Pierre-Louis Bossart
2020-01-10 6:48 ` Vinod Koul
2020-01-10 16:30 ` [alsa-devel] " Pierre-Louis Bossart
2020-01-11 11:30 ` Pierre-Louis Bossart [this message]
2020-01-13 5:22 ` Vinod Koul
2020-01-08 17:54 ` [PATCH 3/6] soundwire: stream: only prepare stream when it is configured Pierre-Louis Bossart
2020-01-08 17:54 ` [PATCH 4/6] soundwire: stream: do not update parameters during DISABLED-PREPARED transition Pierre-Louis Bossart
2020-01-10 6:55 ` Vinod Koul
2020-01-10 16:11 ` [alsa-devel] " Pierre-Louis Bossart
2020-01-08 17:54 ` [PATCH 5/6] soundwire: stream: fix support for multiple Slaves on the same link Pierre-Louis Bossart
2020-01-08 17:54 ` [PATCH 6/6] soundwire: stream: don't program ports for a stream that has not been prepared Pierre-Louis Bossart
2020-01-10 7:03 ` Vinod Koul
2020-01-10 16:24 ` [alsa-devel] " Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69ad48b0-fa3c-904a-4106-5cd9bd18de5c@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=jank@cadence.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rander.wang@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=slawomir.blauciak@intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.de \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).