From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933713AbcKGTLB (ORCPT ); Mon, 7 Nov 2016 14:11:01 -0500 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:60810 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932817AbcKGTK7 (ORCPT ); Mon, 7 Nov 2016 14:10:59 -0500 Subject: Re: [PATCHv7 07/11] i2c: match dt-style device names from sysfs interface To: Kieran Bingham , Wolfram Sang , Lee Jones References: <1478522866-29620-1-git-send-email-kieran@bingham.xyz> <1478522866-29620-8-git-send-email-kieran@bingham.xyz> Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, sameo@linux.intel.com From: Javier Martinez Canillas Message-ID: <69b56515-2799-0c16-06a5-d3709d0be751@osg.samsung.com> Date: Mon, 7 Nov 2016 16:10:51 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1478522866-29620-8-git-send-email-kieran@bingham.xyz> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Kieran, On 11/07/2016 09:47 AM, Kieran Bingham wrote: > A user can choose to instantiate a device on an i2c bus using the sysfs > interface by providing a string and address to match and communicate > with the device on the bus. Presently this string is only matched > against the old i2c device id style strings, even in the presence of > full device tree compatible strings with vendor prefixes. > > Providing a vendor-prefixed string to the sysfs interface will not match > against the device tree of_match_device() calls as there is no device > tree node to parse from the sysfs interface. > > Convert i2c_of_match_device_strip_vendor() such that it can match both > vendor prefixed and stripped compatible strings on the sysfs interface. > > Signed-off-by: Kieran Bingham > Patch looks good to me. Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America