From: Saeed Mahameed <saeedm@mellanox.com>
To: "davem@davemloft.net" <davem@davemloft.net>,
"arnd@arndb.de" <arnd@arndb.de>
Cc: "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
Or Gerlitz <ogerlitz@mellanox.com>, Oz Shlomo <ozsh@mellanox.com>,
Paul Blakey <paulb@mellanox.com>, Mark Bloch <markb@mellanox.com>,
Maor Gottlieb <maorg@mellanox.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Eli Britstein <elibr@mellanox.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"leon@kernel.org" <leon@kernel.org>
Subject: Re: [PATCH] net/mlx5e: reduce stack usage in mlx5_eswitch_termtbl_create
Date: Mon, 17 Jun 2019 21:30:34 +0000 [thread overview]
Message-ID: <69c6a9cfe132a4437bc7d481fb9aeddbe57f7114.camel@mellanox.com> (raw)
In-Reply-To: <20190617.140230.537297372523260104.davem@davemloft.net>
On Mon, 2019-06-17 at 14:02 -0700, David Miller wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> Date: Mon, 17 Jun 2019 13:08:22 +0200
>
> > Putting an empty 'mlx5_flow_spec' structure on the stack is a bit
> > wasteful and causes a warning on 32-bit architectures when building
> > with clang -fsanitize-coverage:
> >
> > drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_termtbl.c:
> > In function 'mlx5_eswitch_termtbl_create':
> > drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_termtbl.c:
> > 90:1: error: the frame size of 1032 bytes is larger than 1024 bytes
> > [-Werror=frame-larger-than=]
> >
> > Since the structure is never written to, we can statically allocate
> > it to avoid the stack usage. To be on the safe side, mark all
> > subsequent function arguments that we pass it into as 'const'
> > as well.
> >
> > Fixes: 10caabdaad5a ("net/mlx5e: Use termination table for VLAN
> > push actions")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Saeed, once Arnd fixes the reverse christmas tree issue, I assume you
> will take
> this in via your tree?
Yes, this is a core change that might conflict with some ongoing stuff.
Thank you Dave !
Saeed.
prev parent reply other threads:[~2019-06-17 21:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 11:08 [PATCH] net/mlx5e: reduce stack usage in mlx5_eswitch_termtbl_create Arnd Bergmann
2019-06-17 18:02 ` Saeed Mahameed
2019-06-17 18:24 ` Mark Bloch
2019-06-17 21:02 ` David Miller
2019-06-17 21:30 ` Saeed Mahameed [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69c6a9cfe132a4437bc7d481fb9aeddbe57f7114.camel@mellanox.com \
--to=saeedm@mellanox.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=elibr@mellanox.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=maorg@mellanox.com \
--cc=markb@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=ozsh@mellanox.com \
--cc=paulb@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).