From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D864C433E9 for ; Sat, 20 Feb 2021 18:45:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F418D64DE8 for ; Sat, 20 Feb 2021 18:45:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229925AbhBTSow (ORCPT ); Sat, 20 Feb 2021 13:44:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229884AbhBTSos (ORCPT ); Sat, 20 Feb 2021 13:44:48 -0500 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 246ABC06178B for ; Sat, 20 Feb 2021 10:44:08 -0800 (PST) Received: by mail-lj1-x233.google.com with SMTP id e17so42675622ljl.8 for ; Sat, 20 Feb 2021 10:44:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=tykDSNBQyBWy4Y86qvV5HFG7OJitL0SuiJFGnG8I3rM=; b=r0EPXWZGv4/NlyMklT9yopa3l5vE9pVO1jbbfvz27OK0kq234TDt/DfTzaH+LOQaN2 CN+24t2KAstxrkNR+SSTdp7+hoaYdVpP8VOVDFW5JJR59j2WegQBkjOw5cyx+O6mHOLp Hzbej3lEYuv/5z8XS8enXoet42DgdO09GmkwUDNmIp7jovpmqM3oKExc4IZhIXDVEbYD oHXzjfWIzDQWwX/HLUg1m5NRdj9I3xkLoaWbvaCWd8jBgwcGdtEijkL6DtPRlfh0xsDc t3avfZSrtRBY/13tAQzixddlA+PG5Ka3hMzSlHW6gxPvhzTivscvTMEjQurfN9tlJIdy sY8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=tykDSNBQyBWy4Y86qvV5HFG7OJitL0SuiJFGnG8I3rM=; b=Vq222FJqJW0I4e9wDvDO4M/Qg/zdRQv3v754/NJaHoQch8k7nl/PJcDYror50vwzcV 3WC0xLbjiBOGa7fkQF7L/6XsW0cE+Fkt43H1V5jSoPC/FBBPFw5XkQJds4Ezdji1Kjo3 tCcTTwWkuZZc+jf5xEbxaBZfyfbKD0Aj60zvBMAvZYZ5HPjxQxUSxTItnfpXAt43udyC I4QJikjuOb6XWGfNBokS0ryrzjwqU65zMJTPurQzl2vnKo/rv7JiVO0x6KwQHHmoTBCY k3Ks9ZnaMDK91SlwYVpnh9laUp5ymFwbIJ/uJ98rUcEAjkDvY+O6yhBQOfwjo6rob5zw lEAw== X-Gm-Message-State: AOAM532xXZacsjox2cUGpABhohItRNPV/cleqPhSnqAQdWt+rKqcZ5gS zUbVMUx5/1YV+s7eq6FC+PWAcQ== X-Google-Smtp-Source: ABdhPJzzCOoRpf3qhkAYfl757QlNomIJ3iDADZ5FbjXc75O1jpMKdr61UWhI1bU8+vRk9vhkonwT5Q== X-Received: by 2002:a2e:948:: with SMTP id 69mr2098073ljj.480.1613846646623; Sat, 20 Feb 2021 10:44:06 -0800 (PST) Received: from [192.168.118.216] ([85.249.43.69]) by smtp.gmail.com with ESMTPSA id x31sm1353093lfu.10.2021.02.20.10.44.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 20 Feb 2021 10:44:05 -0800 (PST) Subject: Re: [PATCH v5 01/22] media: camss: Fix vfe_isr_comp_done() documentation To: Robert Foss , agross@kernel.org, bjorn.andersson@linaro.org, todor.too@gmail.com, mchehab@kernel.org, robh+dt@kernel.org, angelogioacchino.delregno@somainline.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, AngeloGioacchino Del Regno , Sakari Ailus , Nicolas Boichat Cc: Rob Herring , Tomasz Figa , Azam Sadiq Pasha Kapatrala Syed , Sarvesh Sridutt , Laurent Pinchart , Jonathan Marek References: <20210217112122.424236-1-robert.foss@linaro.org> <20210217112122.424236-2-robert.foss@linaro.org> From: Andrey Konovalov Message-ID: <69de93cd-8dee-56f2-12f8-317093c462f0@linaro.org> Date: Sat, 20 Feb 2021 21:44:04 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210217112122.424236-2-robert.foss@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Robert, Reviewed-by: Andrey Konovalov Thanks, Andrey On 17.02.2021 14:21, Robert Foss wrote: > Function name is comment is wrong, and was changed to be > the same as the actual function name. > > The comment was changed to kerneldoc format. > > Signed-off-by: Robert Foss > --- > > Changes since v1 > - Bjorn: Fix function doc name & use kerneldoc format > > > drivers/media/platform/qcom/camss/camss-vfe.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c > index fae2b513b2f9..94c9ca7d5cbb 100644 > --- a/drivers/media/platform/qcom/camss/camss-vfe.c > +++ b/drivers/media/platform/qcom/camss/camss-vfe.c > @@ -1076,8 +1076,8 @@ static void vfe_isr_wm_done(struct vfe_device *vfe, u8 wm) > spin_unlock_irqrestore(&vfe->output_lock, flags); > } > > -/* > - * vfe_isr_wm_done - Process composite image done interrupt > +/** > + * vfe_isr_comp_done() - Process composite image done interrupt > * @vfe: VFE Device > * @comp: Composite image id > */ >