From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52F96C2D0CE for ; Fri, 3 Jan 2020 04:52:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1349C222C3 for ; Fri, 3 Jan 2020 04:52:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="qwvTSnua" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727183AbgACEwb (ORCPT ); Thu, 2 Jan 2020 23:52:31 -0500 Received: from mail26.static.mailgun.info ([104.130.122.26]:30345 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725972AbgACEwa (ORCPT ); Thu, 2 Jan 2020 23:52:30 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1578027150; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=h3CAvHRg41/nLwpsFZGH4BlaH2fRpjNRkJnpauLlfgw=; b=qwvTSnuaCwje/8CA2BKLs7otKONMizsWQivKul5fXxOHzrBlnaemFd0034HNslHYXXhxviJO yondVn+G2pfpz03RBd//D2EGTh28cqMQs/KJmAUh9XCVRCjjkc5pJMfJ6ocQg8Q360ruNoxu CJjZzBKaLTCtcnq+Kovg6mge7BI= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e0ec88c.7fdadcce9260-smtp-out-n02; Fri, 03 Jan 2020 04:52:28 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 60DDDC43383; Fri, 3 Jan 2020 04:52:27 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: wgong) by smtp.codeaurora.org (Postfix) with ESMTPSA id BF18BC433CB; Fri, 3 Jan 2020 04:52:26 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 03 Jan 2020 12:52:26 +0800 From: Wen Gong To: David Miller Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ath11k@lists.infradead.org Subject: Re: [PATCH] net: qrtr: fix len of skb_put_padto in qrtr_node_enqueue In-Reply-To: <297b94fe2eb5a20c75c2095e9640a495@codeaurora.org> References: <20191231093242.6320-1-wgong@codeaurora.org> <20200102.162249.948673283541180133.davem@davemloft.net> <297b94fe2eb5a20c75c2095e9640a495@codeaurora.org> Message-ID: <69f125876df44373236d0068dff8478d@codeaurora.org> X-Sender: wgong@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-01-03 09:37, Wen Gong wrote: > On 2020-01-03 08:22, David Miller wrote: > >> I don't think this is correct. >> >> The 'hdr' was already "pushed" earlier in this file. >> >> Here we are padding the area after the header, which is being "put". >> >> I'm not applying this. If you still think it is correct, you must >> explain >> in detail why it is and add that description to the commit log >> message. >> >> Thank you. > > Thanks David. > I will add more description and send patch v2. v2: http://patchwork.ozlabs.org/patch/1217201/