* [PATCH] x86/fixmap: update stale comments
@ 2019-08-09 11:46 Cao jin
2019-08-15 2:44 ` Cao jin
2019-08-23 2:12 ` [tip: x86/mm] x86/fixmap: Cleanup outdated comments tip-bot2 for Cao jin
0 siblings, 2 replies; 3+ messages in thread
From: Cao jin @ 2019-08-09 11:46 UTC (permalink / raw)
To: linux-kernel, x86; +Cc: tglx, bp, hpa, mingo
Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
---
arch/x86/include/asm/fixmap.h | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/x86/include/asm/fixmap.h b/arch/x86/include/asm/fixmap.h
index 9da8cccdf3fb..0c47aa82e2e2 100644
--- a/arch/x86/include/asm/fixmap.h
+++ b/arch/x86/include/asm/fixmap.h
@@ -42,8 +42,7 @@
* Because of this, FIXADDR_TOP x86 integration was left as later work.
*/
#ifdef CONFIG_X86_32
-/* used by vmalloc.c, vsyscall.lds.S.
- *
+/*
* Leave one empty page between vmalloc'ed areas and
* the start of the fixmap.
*/
@@ -120,7 +119,7 @@ enum fixed_addresses {
* before ioremap() is functional.
*
* If necessary we round it up to the next 512 pages boundary so
- * that we can have a single pgd entry and a single pte table:
+ * that we can have a single pmd entry and a single pte table:
*/
#define NR_FIX_BTMAPS 64
#define FIX_BTMAPS_SLOTS 8
--
2.17.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/fixmap: update stale comments
2019-08-09 11:46 [PATCH] x86/fixmap: update stale comments Cao jin
@ 2019-08-15 2:44 ` Cao jin
2019-08-23 2:12 ` [tip: x86/mm] x86/fixmap: Cleanup outdated comments tip-bot2 for Cao jin
1 sibling, 0 replies; 3+ messages in thread
From: Cao jin @ 2019-08-15 2:44 UTC (permalink / raw)
To: linux-kernel, x86; +Cc: tglx, bp, hpa, mingo
Hi,
Wish to know whether the patch make sense.
On 8/9/19 7:46 PM, Cao jin wrote:
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
> arch/x86/include/asm/fixmap.h | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/x86/include/asm/fixmap.h b/arch/x86/include/asm/fixmap.h
> index 9da8cccdf3fb..0c47aa82e2e2 100644
> --- a/arch/x86/include/asm/fixmap.h
> +++ b/arch/x86/include/asm/fixmap.h
> @@ -42,8 +42,7 @@
> * Because of this, FIXADDR_TOP x86 integration was left as later work.
> */
> #ifdef CONFIG_X86_32
> -/* used by vmalloc.c, vsyscall.lds.S.
> - *
> +/*
Not seeing variable __FIXADDR_TOP & macro FIXADDR_TOP under
CONFIG_X86_32 referred in vmalloc.c, and there is no vsyscall.lds.S now.
> * Leave one empty page between vmalloc'ed areas and
> * the start of the fixmap.
> */
> @@ -120,7 +119,7 @@ enum fixed_addresses {
> * before ioremap() is functional.
> *
> * If necessary we round it up to the next 512 pages boundary so
> - * that we can have a single pgd entry and a single pte table:
> + * that we can have a single pmd entry and a single pte table:
The comments seems missed to be updated in an ancient commit 551889a6e2a24
> */
> #define NR_FIX_BTMAPS 64
> #define FIX_BTMAPS_SLOTS 8
>
--
Sincerely,
Cao jin
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip: x86/mm] x86/fixmap: Cleanup outdated comments
2019-08-09 11:46 [PATCH] x86/fixmap: update stale comments Cao jin
2019-08-15 2:44 ` Cao jin
@ 2019-08-23 2:12 ` tip-bot2 for Cao jin
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot2 for Cao jin @ 2019-08-23 2:12 UTC (permalink / raw)
To: linux-tip-commits; +Cc: linux-kernel, Thomas Gleixner, Cao jin
The following commit has been merged into the x86/mm branch of tip:
Commit-ID: c84b82dd3e593db217f23c60f7edae02c76a3c4c
Gitweb: https://git.kernel.org/tip/c84b82dd3e593db217f23c60f7edae02c76a3c4c
Author: Cao jin <caoj.fnst@cn.fujitsu.com>
AuthorDate: Fri, 09 Aug 2019 19:46:12 +08:00
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Mon, 19 Aug 2019 21:50:19 +02:00
x86/fixmap: Cleanup outdated comments
Remove stale comments and fix the not longer valid pagetable entry
reference.
Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lkml.kernel.org/r/20190809114612.2569-1-caoj.fnst@cn.fujitsu.com
---
arch/x86/include/asm/fixmap.h | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/x86/include/asm/fixmap.h b/arch/x86/include/asm/fixmap.h
index 9da8ccc..0c47aa8 100644
--- a/arch/x86/include/asm/fixmap.h
+++ b/arch/x86/include/asm/fixmap.h
@@ -42,8 +42,7 @@
* Because of this, FIXADDR_TOP x86 integration was left as later work.
*/
#ifdef CONFIG_X86_32
-/* used by vmalloc.c, vsyscall.lds.S.
- *
+/*
* Leave one empty page between vmalloc'ed areas and
* the start of the fixmap.
*/
@@ -120,7 +119,7 @@ enum fixed_addresses {
* before ioremap() is functional.
*
* If necessary we round it up to the next 512 pages boundary so
- * that we can have a single pgd entry and a single pte table:
+ * that we can have a single pmd entry and a single pte table:
*/
#define NR_FIX_BTMAPS 64
#define FIX_BTMAPS_SLOTS 8
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-23 2:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-09 11:46 [PATCH] x86/fixmap: update stale comments Cao jin
2019-08-15 2:44 ` Cao jin
2019-08-23 2:12 ` [tip: x86/mm] x86/fixmap: Cleanup outdated comments tip-bot2 for Cao jin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).