From: Frank Wunderlich <linux@fw-web.de>
To: Hsin-Yi Wang <hsinyi@chromium.org>
Cc: "moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>, CK Hu <ck.hu@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
lkml <linux-kernel@vger.kernel.org>,
stable@vger.kernel.org,
Frank Wunderlich <frank-w@public-files.de>
Subject: Re: [PATCH] soc: mmsys: mediatek: add mask to mmsys routes
Date: Thu, 29 Jul 2021 07:53:58 +0200 [thread overview]
Message-ID: <6BFE13A3-6A42-455E-BDF7-CD285CC6C66D@fw-web.de> (raw)
In-Reply-To: <CAJMQK-gQeMidjBZ1E=ReMmffC5G8oiFawB4Ey1PNb2ZWXw_1Bg@mail.gmail.com>
Am 29. Juli 2021 07:47:03 MESZ schrieb Hsin-Yi Wang <hsinyi@chromium.org>:
>On Thu, Jul 29, 2021 at 1:40 PM Frank Wunderlich <linux@fw-web.de>
>wrote:
>>
>
>>
> struct mtk_mmsys_routes {
> u32 from_comp;
> u32 to_comp;
> u32 addr;
> + u32 mask;
> u32 val;
> };
>mask is not the last element, and mmsys_mt8183_routing_table = {
> {
> DDP_COMPONENT_OVL0, DDP_COMPONENT_OVL_2L0,
> MT8183_DISP_OVL0_MOUT_EN, MT8183_OVL0_MOUT_EN_OVL0_2L
> }
>...
>so the mask and val will be wrong. CK, do you know what mask we should
>set for mt8183? Or can we just set a dummy 0 mask.
Ahhh...mt8183 has own mmsys-table and
i had only changed the default one,so
value is now missing because value is now the mask. I have used same order as
CK to avoid confusion and make it easier
to review.
Afaik you could use same value as value to reset same bits...did this in default routing table too.
regards Frank
next prev parent reply other threads:[~2021-07-29 5:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 17:40 [PATCH] soc: mmsys: mediatek: add mask to mmsys routes Frank Wunderlich
2021-07-28 23:37 ` Chun-Kuang Hu
2021-07-29 3:15 ` Hsin-Yi Wang
2021-07-29 3:42 ` CK Hu
2021-07-29 5:40 ` Frank Wunderlich
2021-07-29 5:47 ` Hsin-Yi Wang
2021-07-29 5:53 ` Frank Wunderlich [this message]
2021-07-29 5:58 ` Hsin-Yi Wang
2021-07-29 6:45 ` Frank Wunderlich
2021-07-29 6:47 ` Hsin-Yi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6BFE13A3-6A42-455E-BDF7-CD285CC6C66D@fw-web.de \
--to=linux@fw-web.de \
--cc=ck.hu@mediatek.com \
--cc=enric.balletbo@collabora.com \
--cc=frank-w@public-files.de \
--cc=hsinyi@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).