From: Paul Cercueil <paul@crapouillou.net>
To: 周琰杰 <zhouyanjie@wanyeetech.com>
Cc: ohad@wizery.com, bjorn.andersson@linaro.org,
mathieu.poirier@linaro.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, linux-remoteproc@vger.kernel.org,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
dongsheng.qiu@ingenic.com, aric.pzqi@ingenic.com,
rick.tyliu@ingenic.com, sihui.liu@ingenic.com,
jun.jiang@ingenic.com, sernia.zhou@foxmail.com
Subject: Re: [PATCH 1/2] dt-bindings: remoteproc: Add bindings for new Ingenic SoCs.
Date: Sat, 24 Jul 2021 12:02:30 +0100 [thread overview]
Message-ID: <6CXQWQ.XVALRMYW4LM72@crapouillou.net> (raw)
In-Reply-To: <1627117898-125239-2-git-send-email-zhouyanjie@wanyeetech.com>
Hi Zhou,
Le sam., juil. 24 2021 at 17:11:37 +0800, 周琰杰 (Zhou Yanjie)
<zhouyanjie@wanyeetech.com> a écrit :
> Add the remoteproc bindings for the JZ4760 SoC, the JZ4760B SoC,
> the JZ4775 SoC, and the JZ4780 SoC from Ingenic.
>
> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
> ---
> .../bindings/remoteproc/ingenic,vpu.yaml | 74
> ++++++++++++++++------
> 1 file changed, 56 insertions(+), 18 deletions(-)
>
> diff --git
> a/Documentation/devicetree/bindings/remoteproc/ingenic,vpu.yaml
> b/Documentation/devicetree/bindings/remoteproc/ingenic,vpu.yaml
> index d0aa91b..6154596 100644
> --- a/Documentation/devicetree/bindings/remoteproc/ingenic,vpu.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/ingenic,vpu.yaml
> @@ -17,31 +17,52 @@ maintainers:
>
> properties:
> compatible:
> - const: ingenic,jz4770-vpu-rproc
> + enum:
> + - ingenic,jz4760-vpu-rproc
> + - ingenic,jz4760b-vpu-rproc
> + - ingenic,jz4770-vpu-rproc
> + - ingenic,jz4775-vpu-rproc
> + - ingenic,jz4780-vpu-rproc
>
> reg:
> - items:
> - - description: aux registers
> - - description: tcsm0 registers
> - - description: tcsm1 registers
> - - description: sram registers
> + oneOf:
> + - items:
> + - description: aux registers
> + - description: tcsm0 registers
> + - description: tcsm1 registers
> + - description: sram registers
> + - items:
> + - description: aux registers
> + - description: tcsm registers
> + - description: sram registers
Since we have "reg-names" already, we don't really need any
description, so you could just have:
reg:
minItems: 3
maxItems: 4
>
> reg-names:
> - items:
> - - const: aux
> - - const: tcsm0
> - - const: tcsm1
> - - const: sram
> + oneOf:
> + - items:
> + - const: aux
> + - const: tcsm0
> + - const: tcsm1
> + - const: sram
> + - items:
> + - const: aux
> + - const: tcsm
> + - const: sram
You could just add "tcsm" to the items list, and add:
minItems: 3
maxItems: 4
>
> clocks:
> - items:
> - - description: aux clock
> - - description: vpu clock
> + oneOf:
> + - items:
> + - description: aux clock
> + - description: vpu clock
> + - items:
> + - description: vpu clock
Same as above, since we already have clock-names, the descriptions
don't bring much.
You can replace with:
clocks:
minItems: 1
maxItems: 2
>
> clock-names:
> - items:
> - - const: aux
> - - const: vpu
> + oneOf:
> + - items:
> + - const: aux
> + - const: vpu
> + - items:
> + - const: vpu
I think you could just add:
minItems: 1
Cheers,
-Paul
>
> interrupts:
> maxItems: 1
> @@ -60,7 +81,7 @@ examples:
> - |
> #include <dt-bindings/clock/jz4770-cgu.h>
>
> - vpu: video-decoder@132a0000 {
> + video-decoder@132a0000 {
> compatible = "ingenic,jz4770-vpu-rproc";
>
> reg = <0x132a0000 0x20>, /* AUX */
> @@ -75,3 +96,20 @@ examples:
> interrupt-parent = <&cpuintc>;
> interrupts = <3>;
> };
> + - |
> + #include <dt-bindings/clock/jz4780-cgu.h>
> +
> + video-decoder@132a0000 {
> + compatible = "ingenic,jz4780-vpu-rproc";
> +
> + reg = <0x132a0000 0x20>, /* AUX */
> + <0x132c0000 0x8000>, /* TCSM */
> + <0x132f0000 0x4000>; /* SRAM */
> + reg-names = "aux", "tcsm", "sram";
> +
> + clocks = <&cgu JZ4780_CLK_VPU>;
> + clock-names = "vpu";
> +
> + interrupt-parent = <&intc>;
> + interrupts = <62>;
> + };
> --
> 2.7.4
>
next prev parent reply other threads:[~2021-07-24 11:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-24 9:11 [PATCH 0/2] Add VPU support for new Ingenic SoCs 周琰杰 (Zhou Yanjie)
2021-07-24 9:11 ` [PATCH 1/2] dt-bindings: remoteproc: Add bindings " 周琰杰 (Zhou Yanjie)
2021-07-24 11:02 ` Paul Cercueil [this message]
2021-07-24 13:06 ` Zhou Yanjie
2021-07-24 9:11 ` [PATCH 2/2] remoteproc: Ingenic: Add support " 周琰杰 (Zhou Yanjie)
2021-07-24 11:15 ` Paul Cercueil
2021-07-24 13:32 ` Zhou Yanjie
2021-07-24 19:30 ` kernel test robot
2021-07-25 1:26 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6CXQWQ.XVALRMYW4LM72@crapouillou.net \
--to=paul@crapouillou.net \
--cc=aric.pzqi@ingenic.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dongsheng.qiu@ingenic.com \
--cc=jun.jiang@ingenic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=ohad@wizery.com \
--cc=rick.tyliu@ingenic.com \
--cc=robh+dt@kernel.org \
--cc=sernia.zhou@foxmail.com \
--cc=sihui.liu@ingenic.com \
--cc=zhouyanjie@wanyeetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).