From: "Álvaro Fernández Rojas" <noltari@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Herbert Xu <herbert@gondor.apana.org.au>,
Andrew Lunn <andrew@lunn.ch>, Matt Mackall <mpm@selenic.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
Rikard Falkeborn <rikard.falkeborn@gmail.com>,
linux-crypto@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Stijn Tintel <stijn@linux-ipv6.be>,
ynezz@true.cz
Subject: Re: [PATCH] hwrng: bcm2835: set quality to 1000
Date: Fri, 5 Mar 2021 07:26:29 +0100 [thread overview]
Message-ID: <6D1459DF-A7E1-422C-AA05-655156AEBA23@gmail.com> (raw)
In-Reply-To: <b0cf1be0-4c7c-57ee-fea5-789fe215b85d@gmail.com>
Hi Florian,
> El 4 mar 2021, a las 23:28, Florian Fainelli <f.fainelli@gmail.com> escribió:
>
> On 3/4/21 7:11 AM, Nicolas Saenz Julienne wrote:
>> On Wed, 2021-03-03 at 10:29 +0100, Álvaro Fernández Rojas wrote:
>>> Hi Herbert,
>>>
>>>> El 3 mar 2021, a las 10:20, Herbert Xu <herbert@gondor.apana.org.au> escribió:
>>>>
>>>> On Sat, Feb 20, 2021 at 08:12:45PM +0100, Álvaro Fernández Rojas wrote:
>>>>>
>>>>> I ran rngtest and this is what I got:
>>>>
>>>> This is meaningless except for sources that have not been whitened.
>>>>
>>>> Your justification needs to be based on what the hardware does or
>>>> is documented to do.
>>>
>>> Ok, so I guess that we’re never setting that value to anything since there’s
>>> no public documentation about that ¯\_(ツ)_/¯.
>>
>> @Florian, is there a way you might be able to get the official value?
>
> I will be looking into the documentation this weekend and let you know
> whether we can change the driver's quality accordingly.
Could you do that for iproc-rng200.c too?
> --
> Florian
Best regards,
Álvaro.
next prev parent reply other threads:[~2021-03-05 6:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-20 17:47 [PATCH] hwrng: bcm2835: set quality to 1000 Álvaro Fernández Rojas
2021-02-20 19:09 ` Andrew Lunn
2021-02-20 19:12 ` Álvaro Fernández Rojas
2021-02-20 19:40 ` Andrew Lunn
2021-03-03 9:20 ` Herbert Xu
2021-03-03 9:29 ` Álvaro Fernández Rojas
2021-03-04 15:11 ` Nicolas Saenz Julienne
2021-03-04 22:28 ` Florian Fainelli
2021-03-05 6:26 ` Álvaro Fernández Rojas [this message]
2021-03-12 4:52 ` Florian Fainelli
2021-02-20 19:57 ` [PATCH v2] " Álvaro Fernández Rojas
2021-02-22 19:50 ` [PATCH v3] hwrng: bcm2835: set quality Álvaro Fernández Rojas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6D1459DF-A7E1-422C-AA05-655156AEBA23@gmail.com \
--to=noltari@gmail.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mpm@selenic.com \
--cc=nsaenzjulienne@suse.de \
--cc=rikard.falkeborn@gmail.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=stijn@linux-ipv6.be \
--cc=ynezz@true.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).