linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: David Sterba <dsterba@suse.cz>
Cc: "Robert P. J. Day" <rpjday@crashcourse.ca>,
	linux-kernel@vger.kernel.org, linux-pcmcia@lists.infradead.org,
	akpm@linux-foundation.org, jeff@garzik.org, jkosina@suse.cz,
	jslaby@suse.cz, stephen@symmetric.co.nz, benm@symmetric.co.nz
Subject: Re: [PATCH] ipwireless_cs driver for 4G PC Card
Date: Fri, 7 Dec 2007 01:28:28 +0100	[thread overview]
Message-ID: <6E0FAD91-89C3-48E4-B8FB-4BD682DE6144@holtmann.org> (raw)
In-Reply-To: <200712041833.28743.dsterba@suse.cz>

Hi David,

>> might it not make more sense to put all of that into a new
>> subdirectory, say, /drivers/char/pcmcia/ipwireless_cs?  that way,  
>> it's
>> more modular and it will keep that higher-level directory from
>> potentially getting cluttered with even more drivers.  and it would
>> let you drop the pointless "ipwireless_cs_" prefix from all of those
>> files as well.
>
> ok, will put it into ipwireless, and the _cs suffix will go away as  
> suggested
> elsewhere. The filenames will then get very generic names, do you have
> suggestion for better names? There are many drivers in own directory  
> and
> files inside have the same prefix. Maybe we can use names like ipw- 
> hw.c, etc.

don't use "ipw" as prefix. It is too close to the Intel wireless  
drivers and will only create confusion. The generic filenames in a  
subdirectory don't matter. The module name is what counts.

Regards

Marcel


  reply	other threads:[~2007-12-07  0:30 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-30 12:55 [PATCH] ipwireless_cs driver for 4G PC Card David Sterba
2007-11-30 13:03 ` Robert P. J. Day
2007-12-04 17:33   ` David Sterba
2007-12-07  0:28     ` Marcel Holtmann [this message]
2007-11-30 13:11 ` Jiri Slaby
2007-11-30 13:18 ` Jeff Garzik
2007-11-30 14:20   ` Jiri Kosina
2007-12-01 10:45 ` Marcel Holtmann
2007-12-04 17:23   ` David Sterba
2007-12-12 15:08 ` [PATCH V2] " David Sterba
2007-12-17 10:57   ` Jiri Kosina
2007-12-17 11:22     ` Andrew Morton
2007-12-17 12:58       ` Jiri Kosina
2007-12-17 20:44         ` Andrew Morton
2007-11-30 15:20 [PATCH] " Michael Robb
2007-11-30 15:40 ` Alan Cox
2007-11-30 23:49 Michael Robb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6E0FAD91-89C3-48E4-B8FB-4BD682DE6144@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=akpm@linux-foundation.org \
    --cc=benm@symmetric.co.nz \
    --cc=dsterba@suse.cz \
    --cc=jeff@garzik.org \
    --cc=jkosina@suse.cz \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pcmcia@lists.infradead.org \
    --cc=rpjday@crashcourse.ca \
    --cc=stephen@symmetric.co.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).