From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932360AbcGOJRv (ORCPT ); Fri, 15 Jul 2016 05:17:51 -0400 Received: from mail1.bemta14.messagelabs.com ([193.109.254.107]:22119 "EHLO mail1.bemta14.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932141AbcGOJRr convert rfc822-to-8bit (ORCPT ); Fri, 15 Jul 2016 05:17:47 -0400 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrOKsWRWlGSWpSXmKPExsUSt3Opsa7Jqo5 wg/+/dCymPnzCZjH/yDlWi29XOpgsLu+aw2ax9PpFJovWvUfYHdg81sxbw+ixc9Zddo9NqzrZ PD5vkgtgiWLNzEvKr0hgzdhx8wJzwR32iglTZrE1MC5j62Lk5BASWMYocXazKYjNJmAoMe/Ne 0YQW0RAWeLq970sXYxcHMwC/xkl5m44AtYgLOAl8XL2BlaIIm+Jhg232SFsK4mlT44zg9gsAq oSX1uWATVzcPAKBEg8P6YBYgoJZEhMbrECqeAUMJb4MGE9WCejgKzEl8bVYJ3MAuISt57MZwK xJQQEJJbsOc8MYYtKvHz8jxXClpdY++sJVNxe4vW9dywQtr7Eo8ePGCFsQ4lV0w5Axc0lnrbf ZoKYryOxYPcnNghbW2LZwtdgc3gFBCVOznzCMoFRfBaSM2YhaZmFpGUWkpYFjCyrGDWKU4vKU ot0DU31kooy0zNKchMzc3QNDU30clOLixPTU3MSk4r1kvNzNzECI7WegYFxB+Pf056HGCU5mJ REeTemdIQL8SXlp1RmJBZnxBeV5qQWH2KU4eBQkuAVWAmUEyxKTU+tSMvMAaYMmLQEB4+SCG/ LCqA0b3FBYm5xZjpE6hSjLseCH7fXMgmx5OXnpUqJ854GKRIAKcoozYMbAUtflxhlpYR5GRkY GIR4ClKLcjNLUOVfMYpzMCoJ834HmcKTmVcCt+kV0BFMQEdYm7eDHFGSiJCSamBcUVbYyDbhX sBlW6aTZbzx9VmbeBqlzvHZ+njUzqiLuH7J/raNas60T09FJ995+bxqb/j7i+zPdh0r1jy8dN Lri74pnlXrbvOn37h89vaWqMD3M7O8d/R7GmsyH6uvXjerYFPuBNPor/1Bn+c9PHiFfdq1WxP 8a1uNmxzlbr+b87lix/v6Q7MVlFiKMxINtZiLihMBgM/EkFoDAAA= X-Env-Sender: stwiss.opensource@diasemi.com X-Msg-Ref: server-11.tower-194.messagelabs.com!1468574260!45580341!1 X-Originating-IP: [94.185.165.51] X-StarScan-Received: X-StarScan-Version: 8.77; banners=-,-,- X-VirusChecked: Checked From: Steve Twiss To: Mark Brown CC: DEVICETREE , LINUXKERNEL , Liam Girdwood , "Mark Rutland" , Rob Herring , "Support Opensource" Subject: RE: [PATCH V1] regulator: da9210: addition of device tree support Thread-Topic: [PATCH V1] regulator: da9210: addition of device tree support Thread-Index: AQHR3R1zTMOwELpMYUOIkTTAuPLLz6AYA0yAgAEy0SA= Date: Fri, 15 Jul 2016 09:17:39 +0000 Message-ID: <6ED8E3B22081A4459DAC7699F3695FB70173DAB217@SW-EX-MBX02.diasemi.com> References: <20160713154433.496843FAD9@swsrvapps-01.diasemi.com> <20160714154821.GA30372@sirena.org.uk> In-Reply-To: <20160714154821.GA30372@sirena.org.uk> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.20.26.77] x-kse-attachmentfiltering-interceptor-info: protection disabled x-kse-serverinfo: sw-ex-cashub02.diasemi.com, 9 x-kse-antivirus-interceptor-info: scan successful x-kse-antivirus-info: Clean, bases: 15/07/2016 04:29:00 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14 July 2016 16:48, Mark Brown wrote: > To: Steve Twiss > Cc: DEVICETREE; LINUXKERNEL; Liam Girdwood; Mark Rutland; Rob Herring; > Support Opensource > Subject: Re: [PATCH V1] regulator: da9210: addition of device tree support > > On Wed, Jul 13, 2016 at 04:41:19PM +0100, Steve Twiss wrote: > > > Two files are modified, the driver source file and the binding document. > > Updates for the regulator source file include an .of_match_table entry, node > > match checking in the probe() function for a compatible da9210 string, and > > a new "BUCK" regulator entry. The binding documentation changes have been > > made to reflect these updates. > > If the device only has one regulator and no other functionality I'd > expect the properties to just be in the top level node for the device - > no need to go fiddling around with a subnode to hold another subnode to > hold all the properties. Agreed. I will revert those changes to the device tree and re-submit V2.