From: Steve Twiss <stwiss.opensource@diasemi.com>
To: "'Lee Jones'" <lee.jones@linaro.org>
Cc: "'LINUXKERNEL'" <linux-kernel@vger.kernel.org>,
Support Opensource <Support.Opensource@diasemi.com>
Subject: RE: [PATCH V1] mfd: da9053: ensure the FAULT_LOG is cleared during MFD driver probe
Date: Mon, 15 Aug 2016 12:37:01 +0000 [thread overview]
Message-ID: <6ED8E3B22081A4459DAC7699F3695FB70173DD07A3@SW-EX-MBX02.diasemi.com> (raw)
In-Reply-To: <6ED8E3B22081A4459DAC7699F3695FB70173DCEE9C@SW-EX-MBX02.diasemi.com>
> On 08 August 2016 12:06, Steve Twiss wrote:
> > On 05 August 2016 10:05, Lee Jones wrote:
> > > On Wed, 06 Jul 2016, Steve Twiss wrote:
> > > > From: Steve Twiss <stwiss.opensource@diasemi.com>
> > > >
> > > > Clearance of any the persistent information within the DA9053 FAULT_LOG
> > > > register must be completed during start-up so the fault-log does not
> > > > continue with previous values. A clearance function has been added here in
> > > > the kernel driver because wiping the fault-log cannot be counted on outside
> > > > the Linux kernel.
> >
> > [...]
> >
> > >
> > > Looks like much of the same code. Can you have a pop at generifying
> > > this to avoid any unnecessary duplication?
> >
> > Hi Lee,
> >
> > Although the function looks like those found in both the DA9062 and DA9063 drivers, I was just
> > intending to highlight the "requirement similarities" to clear the fault register on start-up. This
> > requirement for the Dialog PMIC chips extends across those devices, but the function is not
> > really general enough to be merged into the kernel core or reused across other Dialog devices.
> >
> > I don't think there is unnecessary duplication in this particular case for the DA9052/53 driver.
> >
> > This da9052_clear_fault_log() function will apply to both the Dialog DA9052 and DA9053 PMICs
> > and so I am making good use of code re-use in this place. But, this does not extend to the
> > DA9062 or DA9063.
> >
> > I don't think this FAULT_LOG clearance function in this case is really open to generalisation past
> > the DA9052/53 driver.
>
> Hi Lee,
>
[...]
> The fault log function is individual for each chip and would be customisable to meet the needs
> of the customer's target platform.
>
> The function is meant to be individual. This allows for multiple chips in the same platform -- each
> fault log function could be cleared slightly differently in that case.
[...]
Hi Lee,
Do you have any further thoughts on this topic?
Regards,
Steve
next prev parent reply other threads:[~2016-08-15 12:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 15:12 [PATCH V1] mfd: da9053: ensure the FAULT_LOG is cleared during MFD driver probe Steve Twiss
2016-08-05 9:05 ` Lee Jones
2016-08-08 11:05 ` Steve Twiss
2016-08-10 11:02 ` Steve Twiss
2016-08-15 12:37 ` Steve Twiss [this message]
2016-08-15 13:37 ` Lee Jones
2016-08-31 8:52 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ED8E3B22081A4459DAC7699F3695FB70173DD07A3@SW-EX-MBX02.diasemi.com \
--to=stwiss.opensource@diasemi.com \
--cc=Support.Opensource@diasemi.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).