From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S942296AbcJFQ2c convert rfc822-to-8bit (ORCPT ); Thu, 6 Oct 2016 12:28:32 -0400 Received: from mail1.bemta3.messagelabs.com ([195.245.230.165]:9702 "EHLO mail1.bemta3.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S942180AbcJFQ2Y (ORCPT ); Thu, 6 Oct 2016 12:28:24 -0400 X-Brightmail-Tracker: H4sIAAAAAAAAA1WSbUgUURSGuzsfTubk+JW3VZM2k9I0BwnnX1J UWxHZH4UIc6xxZ2HXXXfWWgtKpSCNRCi1VnFXTYv144cSaGqJmliWUYqpZSYu5K5W4icVSDON mt1fzz3ved9z4F4C8Z3ElARnMXOmdFanwj3R5Jbq2Cj71aWkmKp6gimacOKMrbsfY7oqpwBjG xzCmPHFF4BZGrylYEbmljBm4GkZzszf6QbMcMMzD8ZZ8VrBVH94p2ButneL14kCnBm9P4XFe6 vryuuAusU65qEeatqmrmpzKdSNjjxc/WmoDVe3LGd7qOcbdyQQZzFteqrBkoLxNXmzwFjlbbH XPMKzQa9XPvAkfKlqALsdU1g+2EzgFA3LZ34Aif2pDgA7Fk5KjFBOBNqK4yT2o47AHvsMKvcc hV9K+lc5Glb21olegkCpMDiQmyKVSSoB5i6X/I0EVAhcyKlF5MhAOOq0KSSGFAUftr1FZA6Ar skVTOZQWNt8F5X5IJz+/B2V4iG1HxbkCHKZho7ijtWWODgxUorK8fugvXUOlzkS1lRMI/I6Pv DlAydaCAKsG7awbrBYN1isGyx2gDrAHoEzXeJMUTQdnWrSanizntXqouiY2Gg9JwishtOxqUL 0BYO+EYiPv0k8zaD296FOsJ1QqALI0ctLSb5bUw0Xs3hW4M+bMnWc0AmCCUIFycgrouZj4jSc JU2rE3/QmgwJL5U/eU6SScHI6gWtRpZegZ3KQNKVJQqUJPCZ6eu2tb/3HoQo/UggLuLrZeRMe q35f90NAgmg8iNpKd5Lm25eT3eLgxXiYEP1gjTYzP6TlNnA8fVXJ28ri5gvuV6hOVGKB+kXTu /im6rc4fntw3VZp3IzSDqub3foSmGDZbEn6M3PgmzkmPnA476PYa1PjOWztDslOLnfBRPM94Y PJyOJy5bp21sNFfH8IvONrmc1z3vGw5uMo1uOd9WWBJ3J6CzCFOM3lDBxLDOtfGLvNUqFCjxL RyAmgf0DZnjcvnYDAAA= X-Env-Sender: stwiss.opensource@diasemi.com X-Msg-Ref: server-7.tower-217.messagelabs.com!1475771295!57278342!1 X-Originating-IP: [94.185.165.51] X-StarScan-Received: X-StarScan-Version: 8.84; banners=-,-,- X-VirusChecked: Checked From: Steve Twiss To: Guenter Roeck , Wim Van Sebroeck , Dmitry Torokhov , Eduardo Valentin , Zhang Rui CC: DEVICETREE , LINUX-INPUT , LINUX-PM , Lee Jones , Liam Girdwood , Mark Brown , Mark Rutland , Rob Herring , Support Opensource , Zhang Rui , LINUX-KERNEL , LINUX-WATCHDOG Subject: Re: [PATCH V1 04/10] watchdog: da9061: watchdog driver (RFC) Thread-Topic: [PATCH V1 04/10] watchdog: da9061: watchdog driver (RFC) Thread-Index: AdIf7G3rx3dSmMT2SJSSLbYW3V4nog== Date: Thu, 6 Oct 2016 16:28:14 +0000 Message-ID: <6ED8E3B22081A4459DAC7699F3695FB7018CCE242C@SW-EX-MBX02.diasemi.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.20.35.45] x-kse-attachmentfiltering-interceptor-info: protection disabled x-kse-serverinfo: sw-ex-cashub01.diasemi.com, 9 x-kse-antivirus-interceptor-info: scan successful x-kse-antivirus-info: Clean, bases: 06/10/2016 14:30:00 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Guenter, Thanks for your reply. On 06 October 2016 14:28, Guenter Roeck, wrote: > To: Steve Twiss; LINUX-KERNEL; LINUX-WATCHDOG; Wim Van Sebroeck > Subject: Re: [PATCH V1 04/10] watchdog: da9061: watchdog driver [...] > > @@ -180,6 +180,11 @@ static const struct watchdog_info da9062_watchdog_info = { > > .identity = "DA9062 WDT", > > }; > > > > +static const struct watchdog_info da9061_watchdog_info = { > > + .options = WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING, > > + .identity = "DA9061 WDT", > > This adds a lot of complexity to the driver just to be able to display "DA9061". > Why not just change the existing identity to "DA9061/DA9062 WDT" ? This is true. I am using the compatible string to pick a different configuration .data block: { .compatible = "dlg,da9062-watchdog", .data = &da9062_watchdog_info }, { .compatible = "dlg,da9061-watchdog", .data = &da9061_watchdog_info }, when the only real difference between the DA9061 and DA9062 watchdog driver is the name. Functionally they are identical in this case. This was a similar comment in Dialog's internal review on this exact same point. "Why not just report one thing?" My answer to that was because it would allow to distinguish between different chips. The watchdog driver would report the correct chip type, despite the driver always being for DA9062. This exact same thing would happen with da9063-onkey and da9062-thermal also. For the ONKEY it is marginally confused by needing to support 63, but for 62 and 61 it is the same thing. Only the name is different. I have TO:'d Dmitry Torokhov; Eduardo Valentin; Zhang Rui, for that reason. But, it is just my opinion to keep the "name" different. This will not be my decision if accepted into the Linux kernel, but I would like to at least be consistent for DA9061 and DA9062 so ... is this an issue? The same question applies to thermal and onkey as well. Regards, Steve