From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935017AbcJHGeP convert rfc822-to-8bit (ORCPT ); Sat, 8 Oct 2016 02:34:15 -0400 Received: from mail1.bemta3.messagelabs.com ([195.245.230.166]:33631 "EHLO mail1.bemta3.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934761AbcJHGeK (ORCPT ); Sat, 8 Oct 2016 02:34:10 -0400 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrLKsWRWlGSWpSXmKPExsUSt3OpsW745B/ hBq0HrSymPnzCZjH/yDlWi8OLXjBazL9yjdXi/tejjBbfrnQwWdz89I3V4vKuOWwWn3uPMFrc WLeP3eLJwjNMFkuvX2SyaN17BMh92MdmcWvGC1YHfo8189YweuycdZfd49pmMY/Fe14yeWxa1 cnmcefaHjaPnd8b2D0+b5IL4IhizcxLyq9IYM248HIRW8ERwYrbD9+wNjAu5Oti5OIQEljKKL Fl5372LkZODjYBQ4l5b94zgtgiAiESnY++sYEUMQtsYpHoW7MELCEs4Cox6/BvZogiN4kH08+ xQNhREucf/wKLswioSNzbPA3I5uDgFQiQOLO/DiQsJNDILHHhNj+IzSngIHHz2EywVkYBWYkv javBWpkFxCVuPZnPBGJLCAhILNlznhnCFpV4+fgfK4QtL7F6x2QWCNte4vW9d1C2vsSjx48YI WxDiVXTDkDFzSW+b37BCDFfR2LB7k9sELa2xLKFr8Hm8woISpyc+YRlAqP4LCRnzELSMgtJyy wkLQsYWVYxahSnFpWlFukaWuolFWWmZ5TkJmbm6BoaGOvlphYXJ6an5iQmFesl5+duYgQmi3o GBsYdjL+P+x1ilORgUhLl7Z30I1yILyk/pTIjsTgjvqg0J7X4EKMMB4eSBO8ykJxgUWp6akVa Zg4wbcGkJTh4lER47UHSvMUFibnFmekQqVOMilLivFwgCQGQREZpHlwbLFVeYpSVEuZlZGBgE OIpSC3KzSxBlX/FKM7BqCTMWw8yhSczrwRu+iugxUxAi/OXfgFZXJKIkJJqYDRjCDTTjb5i48 op4meWcvHylltH+Gr+bwn6OE1cxP3K9V1s16z9kjs3LFReeW2LaKHgn5niN9n+TlKeGHb5X8P jQD+9qNvsuUuMXLT2LXjKODm68rvD10sqL7ys9s4wiFV+/ep7/ddzKyqSTfO4VN1/PHh3sFaq ve349KVV0+6qXX0dfeqcDacSS3FGoqEWc1FxIgAVgOxxkAMAAA== X-Env-Sender: stwiss.opensource@diasemi.com X-Msg-Ref: server-16.tower-39.messagelabs.com!1475908439!67230554!1 X-Originating-IP: [94.185.165.51] X-StarScan-Received: X-StarScan-Version: 8.84; banners=-,-,- X-VirusChecked: Checked From: Steve Twiss To: Guenter Roeck , Dmitry Torokhov CC: Wim Van Sebroeck , Lee Jones , Eduardo Valentin , Zhang Rui , DEVICETREE , LINUX-INPUT , LINUX-PM , "Liam Girdwood" , Mark Brown , Mark Rutland , Rob Herring , Support Opensource , LINUX-KERNEL , LINUX-WATCHDOG Subject: RE: [PATCH V1 04/10] watchdog: da9061: watchdog driver (RFC) Thread-Topic: [PATCH V1 04/10] watchdog: da9061: watchdog driver (RFC) Thread-Index: AdIf7G3rx3dSmMT2SJSSLbYW3V4nogADY1aAABxkNkAAEifNAAAD2YwwAAnmGwAAAZ2CgAALWSnQ Date: Sat, 8 Oct 2016 06:33:57 +0000 Message-ID: <6ED8E3B22081A4459DAC7699F3695FB7018CCE291E@SW-EX-MBX02.diasemi.com> References: <6ED8E3B22081A4459DAC7699F3695FB7018CCE242C@SW-EX-MBX02.diasemi.com> <20161006184927.GB11915@roeck-us.net> <6ED8E3B22081A4459DAC7699F3695FB7018CCE2732@SW-EX-MBX02.diasemi.com> <20161007170214.GA21349@roeck-us.net> <6ED8E3B22081A4459DAC7699F3695FB7018CCE282C@SW-EX-MBX02.diasemi.com> <20161007233554.GA21386@dtor-ws> <84f51754-cbd4-7a85-6ab6-83e1f47fd936@roeck-us.net> In-Reply-To: <84f51754-cbd4-7a85-6ab6-83e1f47fd936@roeck-us.net> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.20.35.45] x-kse-attachmentfiltering-interceptor-info: protection disabled x-kse-serverinfo: sw-ex-cashub02.diasemi.com, 9 x-kse-antivirus-interceptor-info: scan successful x-kse-antivirus-info: Clean, bases: 08/10/2016 04:23:00 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08 October 2016 01:22, Guenter Roeck wrote: > On 10/07/2016 04:35 PM, Dmitry Torokhov wrote: > > On Fri, Oct 07, 2016 at 06:01:23PM +0000, Steve Twiss wrote: > >> On 07 October 2016 18:02, Guenter Roeck wrote: > >> > >>>> On 06 October 2016 19:49, Guenter Roeck wrote: > >>>>> On Thu, Oct 06, 2016 at 04:28:14PM +0000, Steve Twiss wrote: > >>>>>> I am using the compatible string to pick a different configuration .data block: > >>>>>> { .compatible = "dlg,da9062-watchdog", .data = &da9062_watchdog_info }, > >>>>>> { .compatible = "dlg,da9061-watchdog", .data = &da9061_watchdog_info }, > >>>>>> > >>>>>> But, it is just my opinion to keep the "name" different. > >>>>>> This will not be my decision if accepted into the Linux kernel, but I would like to > >>>>>> at least be consistent for DA9061 and DA9062 so ... is this an issue? > >>>>> > >>>>> FWIW the driver doesn't really need to be updated in the first place. > >>>>> A compatible statement listing both da9061 and da9062 would do it. > >>>> > >>>> I will make the changes you requested: deprecate the existing compatibility > >>>> for da9062-watchdog and make a new compatibility string which combines both > >>>> da9061 and da9062. > >>>> > >>> That is not what I asked for. > >> > >> Ok. Did you mean separate compatible statements with data sections pointing at > >> the same structure? > >> > >> Like this: > >> { .compatible = "dlg,da9062-watchdog", .data = &da9062_watchdog_info }, > >> { .compatible = "dlg,da9061-watchdog", .data = &da9062_watchdog_info }, > >> > >> So this would be the only change needed in the device driver. > > > > If there is no change in IP block then I do not see why we need to > > introduce new names at all. The dts can specify fallback compatible > > stting. Note, it is called *compatible* not "model" or "device id" or > > whatever. So you can just say in DTS: > > > > compatible = "dlg,da9061-watchdog", "dlg,da9062-watchdog"; > > > > and leave the driver alone. That goes for input part as well. You only > > need to add new compatible to the driver when it in fact is > > *incompatible* with the existing blocks. > > > Yes, exactly. Dmitry, Guenter, Thanks for putting things straight on this.