From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751503AbdFFP2C convert rfc822-to-8bit (ORCPT ); Tue, 6 Jun 2017 11:28:02 -0400 Received: from mail1.bemta3.messagelabs.com ([195.245.230.167]:62668 "EHLO mail1.bemta3.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751388AbdFFP2B (ORCPT ); Tue, 6 Jun 2017 11:28:01 -0400 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHKsWRWlGSWpSXmKPExsUSt3Opse6Pk2a RBnduS1g0v2hgtLj/9SijxeVdc9gsps4/zmJxbe9xZgdWj9mX57B73Lm2h81j8sKLzB6fN8l5 rN+ylSmANYo1My8pvyKBNWPXnPUsBauFKla9u8zSwPiLr4uRi0NIYAmjxI5jN9m6GDk52AQMJ ea9ec8IYosA2cvebGAFKWIWeMwosWLrFlaQhLCAi8SxWWtZIIpcJS4tfQ5kcwDZThILrguBhF kEVCRWT/oLNpNXIEDixbfnTBDLnjFKPN3fzQ6S4BQwlpjSsRysiFFAVuJL42pmEJtZQFzi1pP 5TCC2hICAxJI955khbFGJl4//sULY8hJrfz2BittLvL73jgXC1pd49PgRI4RtKLFq2gGouLnE 9/332CDm60gs2P0JytaWWLbwNTPEoYISJ2c+YZnAKD4LyRmzkLTMQtIyC0nLAkaWVYwaxalFZ alFukZGeklFmekZJbmJmTm6hgbGermpxcWJ6ak5iUnFesn5uZsYgfFaz8DAuINx6gm/Q4ySHE xKorzqU80ihfiS8lMqMxKLM+KLSnNSiw8xynBwKEnwbj0BlBMsSk1PrUjLzAEmDpi0BAePkgj v9/1Aad7igsTc4sx0iNQpRkUpcd6LIH0CIImM0jy4NliyusQoKyXMy8jAwCDEU5BalJtZgir/ ilGcg1FJmNcMZApPZl4J3PRXQIuZgBbzXTIBWVySiJCSamCsLVvReGGGjlCA4L1ZEzcIaKh1L fDnsVmtdOTXqgutM8tF+gx1PhqevCFtazZz88KKbS0mVx41reGVeNHdxLX+l4qao3jSpI0mZ+ +3yZhlHdTc4Vr0rJiJyTl4T3Oyv/GUyP29b5Oeqr8UdlbR3HDQuXfXh60Mz2s5+WpaKm93OZW sUT/53U+JpTgj0VCLuag4EQAk0YMzUQMAAA== X-Env-Sender: stwiss.opensource@diasemi.com X-Msg-Ref: server-5.tower-38.messagelabs.com!1496762871!76260836!1 X-Originating-IP: [94.185.165.51] X-StarScan-Received: X-StarScan-Version: 9.4.19; banners=-,-,- X-VirusChecked: Checked From: Steve Twiss To: Paul Gortmaker CC: Support Opensource , Lee Jones , Eric Miao , Mike Rapoport , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 1/4] mfd: da903x: Make it explicitly non-modular Thread-Topic: [PATCH 1/4] mfd: da903x: Make it explicitly non-modular Thread-Index: AQHS3Gn8zig4GbjI+0ifRYCMRb+YnaIWEobAgACIDQCAAVIAIA== Date: Tue, 6 Jun 2017 15:27:50 +0000 Message-ID: <6ED8E3B22081A4459DAC7699F3695FB7018CD92218@SW-EX-MBX02.diasemi.com> References: <20170603130351.13913-1-paul.gortmaker@windriver.com> <20170603130351.13913-2-paul.gortmaker@windriver.com> <6ED8E3B22081A4459DAC7699F3695FB7018CD91D68@SW-EX-MBX02.diasemi.com> <20170605192944.GI29293@windriver.com> In-Reply-To: <20170605192944.GI29293@windriver.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.20.26.77] x-kse-attachmentfiltering-interceptor-info: protection disabled x-kse-serverinfo: sw-ex-cashub02.diasemi.com, 9 x-kse-antivirus-interceptor-info: scan successful x-kse-antivirus-info: Clean, bases: 06/06/2017 14:17:00 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paul, On 05 June 2017 20:30, Paul Gortmaker wrote: > Subject: Re: [PATCH 1/4] mfd: da903x: Make it explicitly non-modular > > [RE: [PATCH 1/4] mfd: da903x: Make it explicitly non-modular] > On 05/06/2017 (Mon 10:30) Steve Twiss wrote: > > > On 03 June 2017 14:04 Paul Gortmaker wrote: > > > The Kconfig currently controlling compilation of this code is: > > > > > > drivers/mfd/Kconfig:config PMIC_DA903X > > > drivers/mfd/Kconfig: bool "Dialog Semiconductor DA9030/DA9034 PMIC > > > Support" > > > > > > ...meaning that it currently is not being built as a module by anyone. > > > > With regards to your four patches, > > > > [4/4] mfd: da9055-i2c: Make it explicitly non-modular - - - 2017-06-03 > > [3/4] mfd: da9055-core: make it explicitly non-modular - - - 2017-06-03 > > [2/4] mfd: da9052-*: Make it explicitly non-modular - - - 2017-06-03 > > [1/4] mfd: da903x: Make it explicitly non-modular - - - 2017-06-03 > > > > Is there an reason not to make the Kconfig tristate? > > Would that not be simpler? > > I explicitly covered that in the 0/4 e-mail: Apologies, I don't seem to have been CC'ed on the 0/4 e-mail, although I got the others. Dialog's developer e-mail addresses come as part of the Support Opensource e-mail distribution list. > As always, the option exists for someone with the hardware and the desire > to extend the functionality to make any given driver tristate. But given > the number of these tree wide and the fact that I can't test that new > extended functionality in all cases, I just make the code consistent with > existing Kconfig/Makefile settings that currently restrict them to "bool". I see your point, however we have many customers and it is unclear whether they are using modules for any of these drivers. Even if that feature in Kconfig is not enabled, it is possible a tristate change has been made and is being used, but has not been pushed back into the Linux mainline. So I would recommend against removing this feature. The driver code is being supported by Dialog Semiconductor, where possible. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/MAINTAINERS?h=v4.12-rc4#n3984 If there is a question about supporting modules in these drivers, we have the ability to test on target for da9055/52. Regards, Steve