From: Steve Twiss <stwiss.opensource@diasemi.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
"Kuninori Morimoto" <kuninori.morimoto.gx@renesas.com>,
Support Opensource <Support.Opensource@diasemi.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Arjan van de Ven <arjan@linux.intel.com>,
Jacob Pan <jacob.jun.pan@linux.intel.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 3/3] thermal: da9062/61: Prevent hardware access during system suspend
Date: Wed, 17 Oct 2018 08:57:05 +0000 [thread overview]
Message-ID: <6ED8E3B22081A4459DAC7699F3695FB7021C4CCFCB@SW-EX-MBX02.diasemi.com> (raw)
In-Reply-To: <20181012072017.10765-4-geert+renesas@glider.be>
Hi Geert,
Many thanks for looking at this.
On 12 October 2018 08:20 Geert Uytterhoeven wrote:
> Subject: [PATCH v2 3/3] thermal: da9062/61: Prevent hardware access during
> system suspend
>
> The workqueue used for monitoring the hardware may run while the device
> is already suspended. Fix this by using the freezable system workqueue
> instead, cfr. commit 51e20d0e3a60cf46 ("thermal: Prevent polling from
> happening during system suspend").
My thinking was: this device is a PMIC and it will power the system. So when
the device is turned off, the S/W will also not be running.
Although my assumption only works if the PMIC device is the primary system
power -- this has always been the case so far. And although I don't have any
evidence this will change, it may become untrue in the future of course.
> Fixes: 608567aac3206ae8 ("thermal: da9062/61: Thermal junction temperature
> monitoring driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Untested due to lack of hardware.
So, I have not been able to make any time to test this patch yet -- and with
current workloads this might take a bit of time before I get to it.
Regards,
Steve
> v2:
> - No changes.
> ---
> drivers/thermal/da9062-thermal.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/da9062-thermal.c b/drivers/thermal/da9062-
> thermal.c
> index dd8dd947b7f0737c..01b0cb9944577851 100644
> --- a/drivers/thermal/da9062-thermal.c
> +++ b/drivers/thermal/da9062-thermal.c
> @@ -106,7 +106,7 @@ static void da9062_thermal_poll_on(struct work_struct
> *work)
> THERMAL_EVENT_UNSPECIFIED);
>
> delay = msecs_to_jiffies(thermal->zone->passive_delay);
> - schedule_delayed_work(&thermal->work, delay);
> + queue_delayed_work(system_freezable_wq, &thermal->work,
> delay);
> return;
> }
>
> @@ -125,7 +125,7 @@ static irqreturn_t da9062_thermal_irq_handler(int irq,
> void *data)
> struct da9062_thermal *thermal = data;
>
> disable_irq_nosync(thermal->irq);
> - schedule_delayed_work(&thermal->work, 0);
> + queue_delayed_work(system_freezable_wq, &thermal->work, 0);
>
> return IRQ_HANDLED;
> }
> --
> 2.17.1
next prev parent reply other threads:[~2018-10-17 8:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-12 7:20 [PATCH v2 0/3] thermal: Fix workqueue-related issues in drivers Geert Uytterhoeven
2018-10-12 7:20 ` [PATCH v2 1/3] thermal: rcar_thermal: Prevent hardware access during system suspend Geert Uytterhoeven
2018-10-12 7:20 ` [PATCH v2 2/3] thermal: rcar_thermal: Prevent doing work after unbind Geert Uytterhoeven
2018-10-12 7:20 ` [PATCH v2 3/3] thermal: da9062/61: Prevent hardware access during system suspend Geert Uytterhoeven
2018-10-17 8:57 ` Steve Twiss [this message]
2018-10-17 9:14 ` Geert Uytterhoeven
2018-10-17 10:50 ` Steve Twiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ED8E3B22081A4459DAC7699F3695FB7021C4CCFCB@SW-EX-MBX02.diasemi.com \
--to=stwiss.opensource@diasemi.com \
--cc=Support.Opensource@diasemi.com \
--cc=arjan@linux.intel.com \
--cc=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=geert+renesas@glider.be \
--cc=jacob.jun.pan@linux.intel.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).