linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Frank Wunderlich <frank-w@public-files.de>
To: linux-mediatek@lists.infradead.org,
	Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
	Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: David Airlie <airlied@linux.ie>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Frank Wunderlich <linux@fw-web.de>,
	linux-arm-kernel@lists.infradead.org,
	Enric Balletbo i Serra <enric.balletbo@collabora.com>,
	Collabora Kernel ML <kernel@collabora.com>
Subject: Re: Aw: Re: [PATCH] soc: mediatek: mmsys: fix HDMI output on mt7623/bananapi-r2
Date: Sat, 24 Jul 2021 19:06:11 +0200	[thread overview]
Message-ID: <6EF00182-1FF4-4061-BCE4-E2AD7275211B@public-files.de> (raw)
In-Reply-To: <dbe23d2a-cd29-0782-1b7d-bcb5c6683607@collabora.com>

>On 12.07.21 19:16, Frank Wunderlich wrote:
>> Hi,
>> 
>> it turns out that problem is the read+or of the new value
>> 
>> i reverted my patch and changed
>> 
>> reg = readl_relaxed(mmsys->regs + routes[i].addr) | routes[i].val;
>> writel_relaxed(reg, mmsys->regs + routes[i].addr);
>> 
>> to
>> 
>> writel_relaxed(routes[i].val, mmsys->regs + routes[i].addr);
>> 
>> and it works too, but maybe it breaks other platforms

A gentle ping. Amy further comments which of both ways is the right one (restoring old output select function or write only without read+or)?

regards Frank

  reply	other threads:[~2021-07-24 17:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-10 13:24 Frank Wunderlich
2021-07-12 11:50 ` Dafna Hirschfeld
2021-07-12 12:35   ` Aw: " Frank Wunderlich
2021-07-12 17:16   ` Frank Wunderlich
2021-07-12 17:32     ` Dafna Hirschfeld
2021-07-24 17:06       ` Frank Wunderlich [this message]
2021-07-26  0:27         ` Chun-Kuang Hu
2021-07-26 10:33           ` Aw: " Frank Wunderlich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6EF00182-1FF4-4061-BCE4-E2AD7275211B@public-files.de \
    --to=frank-w@public-files.de \
    --cc=airlied@linux.ie \
    --cc=chunkuang.hu@kernel.org \
    --cc=dafna.hirschfeld@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=enric.balletbo@collabora.com \
    --cc=kernel@collabora.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux@fw-web.de \
    --cc=matthias.bgg@gmail.com \
    --subject='Re: Aw: Re: [PATCH] soc: mediatek: mmsys: fix HDMI output on mt7623/bananapi-r2' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).