From: "H. Nikolaus Schaller" <hns@goldelico.com>
To: "\"周琰杰 (Zhou Yanjie)\"" <zhouyanjie@wanyeetech.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
hminas@synopsys.com, robh+dt@kernel.org, krzk+dt@kernel.org,
linux-usb@vger.kernel.org, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
dragancecavac@yahoo.com, dongsheng.qiu@ingenic.com,
aric.pzqi@ingenic.com, rick.tyliu@ingenic.com,
sernia.zhou@foxmail.com, zhenwenjin@gmail.com,
reimu@sudomaker.com
Subject: Re: [PATCH v2 1/2] dt-bindings: dwc2: Add bindings for new Ingenic SoCs.
Date: Wed, 13 Apr 2022 09:22:54 +0200 [thread overview]
Message-ID: <6F03670F-9040-4560-AD78-CC7A03EC678F@goldelico.com> (raw)
In-Reply-To: <1649788201-87620-2-git-send-email-zhouyanjie@wanyeetech.com>
Hi,
> Am 12.04.2022 um 20:30 schrieb 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>:
>
> Add the dwc2 bindings for the JZ4775 SoC, the JZ4780 SoC, the X1000
> SoC, the X1600 SoC, the X1700 SoC, the X1830 SoC, and the X2000 SoC
> from Ingenic.
>
> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
> Acked-by: Rob Herring <robh@kernel.org>
> ---
>
> Notes:
> v1->v2:
> Add Rob Herring's Acked-by.
>
> Documentation/devicetree/bindings/usb/dwc2.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/dwc2.yaml b/Documentation/devicetree/bindings/usb/dwc2.yaml
> index 4cebce6..c6e8c0b 100644
> --- a/Documentation/devicetree/bindings/usb/dwc2.yaml
> +++ b/Documentation/devicetree/bindings/usb/dwc2.yaml
> @@ -17,6 +17,13 @@ properties:
> oneOf:
> - const: brcm,bcm2835-usb
> - const: hisilicon,hi6220-usb
> + - const: ingenic,jz4775-otg
> + - const: ingenic,jz4780-otg
> + - const: ingenic,x1000-otg
> + - const: ingenic,x1600-otg
> + - const: ingenic,x1700-otg
> + - const: ingenic,x1830-otg
> + - const: ingenic,x2000-otg
I have merged it with my recently proposed removal of
ingenic,jz4780-otg in jz4780.dtsi but there was no dtbscheck
complaint about missing snps,dwc2.
So I think should it be:
- items:
- enum:
- const: ingenic,jz4775-otg
- const: ingenic,jz4780-otg
- const: ingenic,x1000-otg
- const: ingenic,x1600-otg
- const: ingenic,x1700-otg
- const: ingenic,x1830-otg
- const: ingenic,x2000-otg
- const: snps,dwc2
similar to the entry for amlogic?
> - items:
> - const: rockchip,rk3066-usb
> - const: snps,dwc2
> --
> 2.7.4
>
BR and thanks,
Nikolaus
next prev parent reply other threads:[~2022-04-13 7:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 18:29 [PATCH v2 0/2] Add OTG support for Ingenic SoCs 周琰杰 (Zhou Yanjie)
2022-04-12 18:30 ` [PATCH v2 1/2] dt-bindings: dwc2: Add bindings for new " 周琰杰 (Zhou Yanjie)
2022-04-13 7:22 ` H. Nikolaus Schaller [this message]
[not found] ` <c79a8ff7-7a3f-9627-f910-dbbf942e34cb@wanyeetech.com>
2022-04-13 19:30 ` H. Nikolaus Schaller
2022-04-13 19:42 ` Zhou Yanjie
2022-04-14 7:32 ` Krzysztof Kozlowski
2022-04-14 10:00 ` H. Nikolaus Schaller
2022-04-14 17:11 ` Zhou Yanjie
2022-04-14 17:18 ` H. Nikolaus Schaller
2022-04-12 18:30 ` [PATCH v2 2/2] USB: dwc2: Add OTG support for " 周琰杰 (Zhou Yanjie)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6F03670F-9040-4560-AD78-CC7A03EC678F@goldelico.com \
--to=hns@goldelico.com \
--cc=aric.pzqi@ingenic.com \
--cc=devicetree@vger.kernel.org \
--cc=dongsheng.qiu@ingenic.com \
--cc=dragancecavac@yahoo.com \
--cc=gregkh@linuxfoundation.org \
--cc=hminas@synopsys.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=reimu@sudomaker.com \
--cc=rick.tyliu@ingenic.com \
--cc=robh+dt@kernel.org \
--cc=sernia.zhou@foxmail.com \
--cc=zhenwenjin@gmail.com \
--cc=zhouyanjie@wanyeetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).