From: Haakon Bugge <haakon.bugge@oracle.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
OFED mailing list <linux-rdma@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH for-next] RDMA/core/sa_query: Remove unused function
Date: Wed, 11 Aug 2021 12:40:36 +0000 [thread overview]
Message-ID: <6FFA7D21-2B84-4B45-B215-F893B49393AB@oracle.com> (raw)
In-Reply-To: <YRPDlTHjagRUqtOS@unreal>
> On 11 Aug 2021, at 14:33, Leon Romanovsky <leon@kernel.org> wrote:
>
> On Wed, Aug 11, 2021 at 02:27:11PM +0200, Håkon Bugge wrote:
>> ib_sa_service_rec_query() was introduced in kernel v2.6.13 by commit
>> cbae32c56314 ("[PATCH] IB: Add Service Record support to SA client")
>> in 2005. It was not used then and have never been used since.
>>
>> Removing it.
>>
>> Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com>
>> ---
>> drivers/infiniband/core/sa_query.c | 101 -------------------------------------
>> include/rdma/ib_sa.h | 10 ----
>> 2 files changed, 111 deletions(-)
>
> You shouldn't stop there and remove ib_sa_service_rec_callback,
> ib_sa_service_rec_release, ib_sa_service_query and probably
> ib_sa_service_rec.
I checked all functions called from ib_sa_service_rec_query() were used elsewhere, and they were indeed. But overlooked the function assignments :-) Thanks for pointing it out. A v2 will follow.
Thxs, Håkon
prev parent reply other threads:[~2021-08-11 12:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 12:27 [PATCH for-next] RDMA/core/sa_query: Remove unused function Håkon Bugge
2021-08-11 12:33 ` Leon Romanovsky
2021-08-11 12:40 ` Haakon Bugge [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6FFA7D21-2B84-4B45-B215-F893B49393AB@oracle.com \
--to=haakon.bugge@oracle.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).