From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To: Felipe Balbi <balbi@kernel.org>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Wesley Cheng <wcheng@codeaurora.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"agross@kernel.org" <agross@kernel.org>,
"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"frowand.list@gmail.com" <frowand.list@gmail.com>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"jackp@codeaurora.org" <jackp@codeaurora.org>
Subject: Re: [PATCH v14 3/6] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements
Date: Wed, 14 Jul 2021 02:58:41 +0000 [thread overview]
Message-ID: <6a009d83-bb4e-b783-a110-343bc8fb21a6@synopsys.com> (raw)
In-Reply-To: <87czrmzjym.fsf@kernel.org>
Felipe Balbi wrote:
>
> Hi,
>
> Thinh Nguyen <Thinh.Nguyen@synopsys.com> writes:
>> Wesley Cheng wrote:
>>> Some devices have USB compositions which may require multiple endpoints
>>> that support EP bursting. HW defined TX FIFO sizes may not always be
>>> sufficient for these compositions. By utilizing flexible TX FIFO
>>> allocation, this allows for endpoints to request the required FIFO depth to
>>> achieve higher bandwidth. With some higher bMaxBurst configurations, using
>>> a larger TX FIFO size results in better TX throughput.
>>>
>>> By introducing the check_config() callback, the resizing logic can fetch
>>> the maximum number of endpoints used in the USB composition (can contain
>>> multiple configurations), which helps ensure that the resizing logic can
>>> fulfill the configuration(s), or return an error to the gadget layer
>>> otherwise during bind time.
>>>
>>> Signed-off-by: Wesley Cheng <wcheng@codeaurora.org>
>>> ---
>>> drivers/usb/dwc3/core.c | 15 +++
>>> drivers/usb/dwc3/core.h | 16 ++++
>>> drivers/usb/dwc3/ep0.c | 2 +
>>> drivers/usb/dwc3/gadget.c | 232 ++++++++++++++++++++++++++++++++++++++++++++++
>>> 4 files changed, 265 insertions(+)
>>>
<snip>
>>> +/*
>>> + * dwc3_gadget_resize_tx_fifos - reallocate fifo spaces for current use-case
>>> + * @dwc: pointer to our context structure
>>> + *
>>> + * This function will a best effort FIFO allocation in order
>>> + * to improve FIFO usage and throughput, while still allowing
>>> + * us to enable as many endpoints as possible.
>>> + *
>>> + * Keep in mind that this operation will be highly dependent
>>> + * on the configured size for RAM1 - which contains TxFifo -,
>>> + * the amount of endpoints enabled on coreConsultant tool, and
>>> + * the width of the Master Bus.
>>> + *
>>> + * In general, FIFO depths are represented with the following equation:
>>> + *
>>> + * fifo_size = mult * ((max_packet + mdwidth)/mdwidth + 1) + 1
>>> + *
>>> + * In conjunction with dwc3_gadget_check_config(), this resizing logic will
>>> + * ensure that all endpoints will have enough internal memory for one max
>>> + * packet per endpoint.
>>> + */
>>> +static int dwc3_gadget_resize_tx_fifos(struct dwc3_ep *dep)
>>> +{
>>> + struct dwc3 *dwc = dep->dwc;
>>> + int fifo_0_start;
>>> + int ram1_depth;
>>> + int fifo_size;
>>> + int min_depth;
>>> + int num_in_ep;
>>> + int remaining;
>>> + int num_fifos = 1;
>>> + int fifo;
>>> + int tmp;
>>> +
>>> + if (!dwc->do_fifo_resize)
>>> + return 0;
>>> +
>>> + /* resize IN endpoints except ep0 */
>>> + if (!usb_endpoint_dir_in(dep->endpoint.desc) || dep->number <= 1)
>>> + return 0;
>>
>>> +
>>> + ram1_depth = DWC3_RAM1_DEPTH(dwc->hwparams.hwparams7);
>>> +
>>> + if ((dep->endpoint.maxburst > 1 &&
>>> + usb_endpoint_xfer_bulk(dep->endpoint.desc)) ||
>>> + usb_endpoint_xfer_isoc(dep->endpoint.desc))
>>> + num_fifos = 3;
>>> +
>>> + if (dep->endpoint.maxburst > 6 &&
>>> + usb_endpoint_xfer_bulk(dep->endpoint.desc) && DWC3_IP_IS(DWC31))
>>> + num_fifos = dwc->tx_fifo_resize_max_num;
>>
>> Why only bulk? Isoc should be at least equal or more than bulk.
>> Also, make this applicable to DWC_usb32 also.
>
> this should be applicable to all DWC3 versions, no? dwc3, 31 and 32.
>
Yes.
BR,
Thinh
next prev parent reply other threads:[~2021-07-14 2:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-10 9:13 [PATCH v14 0/6] Re-introduce TX FIFO resize for larger EP bursting Wesley Cheng
2021-07-10 9:13 ` [PATCH v14 1/6] usb: gadget: udc: core: Introduce check_config to verify USB configuration Wesley Cheng
2021-07-10 9:13 ` [PATCH v14 2/6] usb: gadget: configfs: Check USB configuration before adding Wesley Cheng
2021-07-10 9:13 ` [PATCH v14 3/6] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements Wesley Cheng
2021-07-12 23:38 ` Thinh Nguyen
2021-07-13 8:39 ` Felipe Balbi
2021-07-14 2:58 ` Thinh Nguyen [this message]
2021-07-14 3:10 ` Thinh Nguyen
2021-07-14 6:40 ` Felipe Balbi
2021-07-14 6:52 ` gregkh
2021-07-14 7:30 ` Wesley Cheng
2021-07-20 11:41 ` gregkh
2021-07-21 6:23 ` Wesley Cheng
2021-07-14 6:51 ` gregkh
2021-07-14 2:59 ` Thinh Nguyen
2021-07-10 9:13 ` [PATCH v14 4/6] of: Add stub for of_add_property() Wesley Cheng
2021-07-10 9:13 ` [PATCH v14 5/6] usb: dwc3: dwc3-qcom: Enable tx-fifo-resize property by default Wesley Cheng
2021-07-10 9:13 ` [PATCH v14 6/6] dt-bindings: usb: dwc3: Update dwc3 TX fifo properties Wesley Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a009d83-bb4e-b783-a110-343bc8fb21a6@synopsys.com \
--to=thinh.nguyen@synopsys.com \
--cc=agross@kernel.org \
--cc=balbi@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jackp@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=wcheng@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).