linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Cezary Rojewski <cezary.rojewski@intel.com>,
	Lukasz Majczak <lma@semihalf.com>
Cc: upstream@semihalf.com, alsa-devel@alsa-project.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v1] ASoC: Intel: kbl_da7219_max98357a: fix drv_name
Date: Fri, 30 Jul 2021 09:12:36 -0500	[thread overview]
Message-ID: <6a0866a7-aec4-69d9-eb70-07931952b732@linux.intel.com> (raw)
In-Reply-To: <c1fb1cd1-6d27-648a-ac9c-81e150505750@intel.com>



On 7/30/21 9:05 AM, Cezary Rojewski wrote:
> On 2021-07-30 3:55 PM, Pierre-Louis Bossart wrote:
>> On 7/30/21 6:59 AM, Lukasz Majczak wrote:
> 
> ...
> 
>>> @@ -113,7 +113,7 @@ struct snd_soc_acpi_mach
>>> snd_soc_acpi_intel_kbl_machines[] = {
>>>       },
>>>       {
>>>           .id = "DLGS7219",
>>> -        .drv_name = "kbl_da7219_mx98373",
>>> +        .drv_name = "kbl_da7219_max98373",
>>
>> this one is wrong though? The correct name was already present, you're
>> reverting back to the wrong name.
>>
>> there's another one that I missed, do you mind changing this as well?
>>
>> soc-acpi-intel-cml-match.c:             .drv_name =
>> "cml_da7219_max98357a",
>>
>> Should be "cml_da7219_mx98357a"
>>
>>
> 
> Not saying 'nay' or 'yay' but why is configuration first available on
> KBL platforms being renamed to 'cml_XXX'?
The same bxt_da7219_max98357a.c machine driver is used for multiple devices.

static const struct platform_device_id bxt_board_ids[] = {
	{ .name = "bxt_da7219_mx98357a" },
	{ .name = "glk_da7219_mx98357a" },
	{ .name = "cml_da7219_mx98357a" },
	{ }
};
MODULE_DEVICE_TABLE(platform, bxt_board_ids);

Why there are different drivers for KBL and BXT is probably lost in history.

      reply	other threads:[~2021-07-30 14:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-30 11:59 Lukasz Majczak
2021-07-30 13:50 ` Cezary Rojewski
2021-07-30 13:55 ` Pierre-Louis Bossart
2021-07-30 14:05   ` Cezary Rojewski
2021-07-30 14:12     ` Pierre-Louis Bossart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a0866a7-aec4-69d9-eb70-07931952b732@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=cezary.rojewski@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lma@semihalf.com \
    --cc=stable@vger.kernel.org \
    --cc=upstream@semihalf.com \
    --subject='Re: [PATCH v1] ASoC: Intel: kbl_da7219_max98357a: fix drv_name' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).