From: Nikolay Borisov <nik.borisov@suse.com>
To: Guenter Roeck <linux@roeck-us.net>, Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
x86@kernel.org, Linus Torvalds <torvalds@linux-foundation.org>,
"Ahmed S. Darwish" <darwi@linutronix.de>,
Arnd Bergmann <arnd@arndb.de>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org,
Huacai Chen <chenhuacai@kernel.org>,
WANG Xuerui <kernel@xen0n.name>,
loongarch@lists.linux.dev,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-m68k@lists.linux-m68k.org,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-mips@vger.kernel.org,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
linux-sh@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
sparclinux@vger.kernel.org, Richard Weinberger <richard@nod.at>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Johannes Berg <johannes@sipsolutions.net>,
linux-um@lists.infradead.org,
Richard Henderson <richard.henderson@linaro.org>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Chris Zankel <chris@zankel.net>,
Tom Lendacky <thomas.lendacky@amd.com>,
semenzato@google.com
Subject: Re: [patch 17/17] x86/fpu: Move FPU initialization into arch_cpu_finalize_init()
Date: Fri, 1 Sep 2023 21:02:19 +0300 [thread overview]
Message-ID: <6a09294e-2c07-585b-336b-20d07e7e08ba@suse.com> (raw)
In-Reply-To: <ba1b11e5-b3f0-457b-8920-d57d470626c3@roeck-us.net>
On 1.09.23 г. 20:30 ч., Guenter Roeck wrote:
> Hi,
>
> On Wed, Jun 14, 2023 at 01:39:46AM +0200, Thomas Gleixner wrote:
>> Initializing the FPU during the early boot process is a pointless
>> exercise. Early boot is convoluted and fragile enough.
>>
>> Nothing requires that the FPU is set up early. It has to be initialized
>> before fork_init() because the task_struct size depends on the FPU register
>> buffer size.
>>
>> Move the initialization to arch_cpu_finalize_init() which is the perfect
>> place to do so.
>>
>> No functional change.
>>
>> This allows to remove quite some of the custom early command line parsing,
>> but that's subject to the next installment.
>>
>> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
>
> The backport of this patch into chromeos-5.10 and chromeos-5.15 via stable
> relase merges is causing various Chromebooks (not all of them) to crash
> early during boot. Subsequent fixes have not addressed the problem for us,
> so we already reverted the patch from chromeos-5.15 and will revert it
> from chromeos-5.10 as well.
>
> I don't know if this is a Chromebook specific problem, or if it affects
> mainline, so this is just a heads-up in case others experience similar
> problems.
Another thing - if you choose to revert the arch_finalize patch then
bear in mind that the GDS' 'force' option is rendered inoperable as the
FPU can't be disabled due to the way things are sequenced.
>
> Thanks,
> Guenter
next prev parent reply other threads:[~2023-09-01 18:02 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 23:39 [patch 00/17] init, treewide, x86: Cleanup check_bugs() and start sanitizing the x86 boot process Thomas Gleixner
2023-06-13 23:39 ` [patch 01/17] init: Provide arch_cpu_finalize_init() Thomas Gleixner
2023-06-14 9:28 ` Borislav Petkov
2023-06-16 9:24 ` [tip: x86/boot] " tip-bot2 for Thomas Gleixner
2023-06-13 23:39 ` [patch 02/17] x86/cpu: Switch to arch_cpu_finalize_init() Thomas Gleixner
2023-06-14 9:53 ` Thomas Gleixner
2023-06-14 10:39 ` Borislav Petkov
2023-06-16 9:24 ` [tip: x86/boot] " tip-bot2 for Thomas Gleixner
2023-06-13 23:39 ` [patch 03/17] ARM: cpu: " Thomas Gleixner
2023-06-16 9:24 ` [tip: x86/boot] " tip-bot2 for Thomas Gleixner
2023-06-25 21:27 ` [patch 03/17] " Philippe Mathieu-Daudé
2023-06-13 23:39 ` [patch 04/17] ia64/cpu: " Thomas Gleixner
2023-06-16 9:24 ` [tip: x86/boot] " tip-bot2 for Thomas Gleixner
2023-06-25 21:24 ` [patch 04/17] " Philippe Mathieu-Daudé
2023-06-13 23:39 ` [patch 05/17] loongarch/cpu: " Thomas Gleixner
2023-06-16 9:24 ` [tip: x86/boot] " tip-bot2 for Thomas Gleixner
2023-06-25 21:24 ` [patch 05/17] " Philippe Mathieu-Daudé
2023-06-13 23:39 ` [patch 06/17] m68k/cpu: " Thomas Gleixner
2023-06-14 9:22 ` Geert Uytterhoeven
2023-06-16 9:24 ` [tip: x86/boot] " tip-bot2 for Thomas Gleixner
2023-06-13 23:39 ` [patch 07/17] mips/cpu: " Thomas Gleixner
2023-06-16 9:24 ` [tip: x86/boot] " tip-bot2 for Thomas Gleixner
2023-06-25 21:25 ` [patch 07/17] " Philippe Mathieu-Daudé
2023-06-13 23:39 ` [patch 08/17] sh/cpu: " Thomas Gleixner
2023-06-16 9:24 ` [tip: x86/boot] " tip-bot2 for Thomas Gleixner
2023-06-25 21:29 ` [patch 08/17] " Philippe Mathieu-Daudé
2023-06-25 21:45 ` John Paul Adrian Glaubitz
2023-06-13 23:39 ` [patch 09/17] sparc/cpu: " Thomas Gleixner
2023-06-14 20:41 ` Sam Ravnborg
2023-06-16 9:24 ` [tip: x86/boot] " tip-bot2 for Thomas Gleixner
2023-06-25 21:30 ` [patch 09/17] " Philippe Mathieu-Daudé
2023-06-13 23:39 ` [patch 10/17] um/cpu: " Thomas Gleixner
2023-06-14 6:51 ` Richard Weinberger
2023-06-16 9:24 ` [tip: x86/boot] " tip-bot2 for Thomas Gleixner
2023-06-25 21:28 ` [patch 10/17] " Philippe Mathieu-Daudé
2023-06-13 23:39 ` [patch 11/17] init: Remove check_bugs() leftovers Thomas Gleixner
2023-06-14 6:14 ` Richard Henderson
2023-06-16 9:24 ` [tip: x86/boot] " tip-bot2 for Thomas Gleixner
2023-06-25 21:31 ` [patch 11/17] " Philippe Mathieu-Daudé
2023-06-13 23:39 ` [patch 12/17] init: Invoke arch_cpu_finalize_init() earlier Thomas Gleixner
2023-06-15 21:44 ` Edgecombe, Rick P
2023-06-15 22:03 ` Thomas Gleixner
2023-06-16 9:24 ` [tip: x86/boot] " tip-bot2 for Thomas Gleixner
2023-06-13 23:39 ` [patch 13/17] init, x86: Move mem_encrypt_init() into arch_cpu_finalize_init() Thomas Gleixner
2023-06-16 9:24 ` [tip: x86/boot] " tip-bot2 for Thomas Gleixner
2023-06-21 17:12 ` [patch 13/17] " Tom Lendacky
2023-06-13 23:39 ` [patch 14/17] x86/init: Initialize signal frame size late Thomas Gleixner
2023-06-16 9:24 ` [tip: x86/boot] " tip-bot2 for Thomas Gleixner
2023-06-13 23:39 ` [patch 15/17] x86/fpu: Remove cpuinfo argument from init functions Thomas Gleixner
2023-06-16 9:24 ` [tip: x86/boot] " tip-bot2 for Thomas Gleixner
2023-06-13 23:39 ` [patch 16/17] x86/fpu: Mark init functions __init Thomas Gleixner
2023-06-16 9:24 ` [tip: x86/boot] " tip-bot2 for Thomas Gleixner
2023-06-13 23:39 ` [patch 17/17] x86/fpu: Move FPU initialization into arch_cpu_finalize_init() Thomas Gleixner
2023-06-14 5:03 ` Chang S. Bae
2023-06-14 9:52 ` Thomas Gleixner
2023-06-16 9:24 ` [tip: x86/boot] " tip-bot2 for Thomas Gleixner
2023-09-01 17:30 ` [patch 17/17] " Guenter Roeck
2023-09-01 18:00 ` Nikolay Borisov
2023-09-01 18:21 ` Guenter Roeck
2023-09-01 18:02 ` Nikolay Borisov [this message]
2023-09-01 21:09 ` Guenter Roeck
2023-06-28 3:38 ` [patch 00/17] init, treewide, x86: Cleanup check_bugs() and start sanitizing the x86 boot process Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a09294e-2c07-585b-336b-20d07e7e08ba@suse.com \
--to=nik.borisov@suse.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=arnd@arndb.de \
--cc=chenhuacai@kernel.org \
--cc=chris@zankel.net \
--cc=dalias@libc.org \
--cc=darwi@linutronix.de \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=johannes@sipsolutions.net \
--cc=kernel@xen0n.name \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=linux@roeck-us.net \
--cc=loongarch@lists.linux.dev \
--cc=mpe@ellerman.id.au \
--cc=richard.henderson@linaro.org \
--cc=richard@nod.at \
--cc=semenzato@google.com \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=torvalds@linux-foundation.org \
--cc=tsbogend@alpha.franken.de \
--cc=x86@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).