linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kieran Bingham <kieran.bingham@ideasonboard.com>
To: Du Changbin <changbin.du@gmail.com>,
	jan.kiszka@siemens.com, kbingham@kernel.org
Cc: linux-kernel@vger.kernel.org,
	Peter Griffin <peter.griffin@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v3] scripts/gdb: fix lx-version
Date: Thu, 25 Oct 2018 09:54:27 +0100	[thread overview]
Message-ID: <6a1ec497-acd7-cd4d-4541-5960e03d955c@ideasonboard.com> (raw)
In-Reply-To: <20181017142442.7818-1-changbin.du@gmail.com>

Hi Du,

Thank you for the updated patch,

On 17/10/2018 15:24, Du Changbin wrote:
> For current gdb version (has tested with 7.3 and 8.1), 'lx-version'
> only prints one character.
> (gdb) lx-version
> L(gdb)
> 
> This can be fixed by casting 'linux_banner' as (char *).
> (gdb) lx-version
> Linux version 4.19.0-rc1+ (changbin@acer) (gcc version 7.3.0 (Ubuntu 7.3.0-16ubuntu3)) #21 SMP Sat Sep 1 21:43:30 CST 2018
> 
> Signed-off-by: Du Changbin <changbin.du@gmail.com>

I'll update the upstream GDB bugzilla [0] regarding this issue - but I
think we need a workaround here, and this is it.

Fixes: 2d061d999424 ("scripts/gdb: add version command")
Reviewed-by: Kieran Bingham <kbingham@kernel.org>

And for reference, this already has an early LGTM from Jan as well.

[0] https://sourceware.org/bugzilla/show_bug.cgi?id=20077



> ---
>  scripts/gdb/linux/proc.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/gdb/linux/proc.py b/scripts/gdb/linux/proc.py
> index 086d27223c0c..0aebd7565b03 100644
> --- a/scripts/gdb/linux/proc.py
> +++ b/scripts/gdb/linux/proc.py
> @@ -41,7 +41,7 @@ class LxVersion(gdb.Command):
>  
>      def invoke(self, arg, from_tty):
>          # linux_banner should contain a newline
> -        gdb.write(gdb.parse_and_eval("linux_banner").string())
> +        gdb.write(gdb.parse_and_eval("(char *)linux_banner").string())
>  
>  LxVersion()


-- 
Regards
--
Kieran

  reply	other threads:[~2018-10-25  8:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-17 14:24 Du Changbin
2018-10-25  8:54 ` Kieran Bingham [this message]
2018-11-05  9:59   ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a1ec497-acd7-cd4d-4541-5960e03d955c@ideasonboard.com \
    --to=kieran.bingham@ideasonboard.com \
    --cc=akpm@linux-foundation.org \
    --cc=changbin.du@gmail.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kbingham@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter.griffin@linaro.org \
    --subject='Re: [PATCH v3] scripts/gdb: fix lx-version' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).