From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
linux-tegra@vger.kernel.org, Jon Hunter <jonathanh@nvidia.com>,
Bard liao <yung-chuan.liao@linux.intel.com>
Subject: Re: [PATCH V2] ASoC: soc-core: Prevent warning if no DMI table is present
Date: Wed, 10 Mar 2021 09:44:07 -0600 [thread overview]
Message-ID: <6a2352e6-f2b7-def1-de58-52fbeb7846e5@linux.intel.com> (raw)
In-Reply-To: <20210310133534.GD4746@sirena.org.uk>
On 3/10/21 7:35 AM, Mark Brown wrote:
> On Tue, Mar 09, 2021 at 01:41:45PM -0600, Pierre-Louis Bossart wrote:
>
>> The problem is that the cards are platform devices created by the parent
>> (which itself may be a PCI or ACPI device) and have nothing to do with ACPI.
>
>> Could we flip the logic and instead explicitly detect OF devices? That
>> restores functionality for us.
>
> Just change it to a system level check for ACPI, checking for OF would
> leave problems for board files or any other alternative firmware
> interfaces.
did you mean if (!IS_ENABLED(CONFIG_ACPI)) ?
next prev parent reply other threads:[~2021-03-10 15:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 11:55 [PATCH V2] ASoC: soc-core: Prevent warning if no DMI table is present Jon Hunter
2021-03-04 0:54 ` Mark Brown
2021-03-09 19:41 ` Pierre-Louis Bossart
2021-03-10 13:35 ` Mark Brown
2021-03-10 15:44 ` Pierre-Louis Bossart [this message]
2021-03-10 16:18 ` Mark Brown
2021-03-10 16:37 ` Takashi Iwai
2021-03-10 16:41 ` Pierre-Louis Bossart
2021-03-10 16:52 ` Mark Brown
2021-03-10 17:50 ` Pierre-Louis Bossart
2021-03-10 18:16 ` Mark Brown
2021-03-10 18:37 ` Pierre-Louis Bossart
2021-03-10 19:17 ` Jon Hunter
2021-03-10 20:16 ` Mark Brown
2021-03-10 16:50 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a2352e6-f2b7-def1-de58-52fbeb7846e5@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=ranjani.sridharan@linux.intel.com \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).