From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Pavel Machek <pavel@ucw.cz>, Willy Tarreau <w@1wt.eu>
Cc: Andreas Klinger <ak@it-klinger.de>,
ben.whitten@gmail.com, geert+renesas@glider.be,
pombredanne@nexb.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH v2] leds: ledtrig-morse: send out morse code
Date: Wed, 4 Jul 2018 22:36:55 +0200 [thread overview]
Message-ID: <6a24e147-f2c7-9d82-0ce6-3238adf892b0@gmail.com> (raw)
In-Reply-To: <20180704181916.GA10785@amd>
Hi All,
On 07/04/2018 08:19 PM, Pavel Machek wrote:
> Hi!
>
>> On Wed, Jul 04, 2018 at 08:53:05AM +0200, Pavel Machek wrote:
>>> As I stated before, I don't think morse encoder belongs in kernel.
>>
>> On the opposite, I think that the kernel needs to be a bit more autonomous
>> when it comes to reporting its own issues. Being able to report a panic
>> when userland cannot be accessed for example is the reason why we've seen
>> various features such as blinking keyboard LEDs for this.
>
> Being able to report panics by blinking would be nice... but proposed
> patch does NOT do that.
Actually we do have already drivers/leds/trigger/ledtrig-panic.c.
>>> LED pattern trigger should be merged, instead.
>>
>> Well, just like we have LED and LED triggers in the kernel, I think having
>> a generic way to use patterns could be nice and in this case Morse could be
>> one such pattern, but if that means it's limited to userland to configure
>> it then it sadly voids all of its benefits.
>
> Proposed patch is already limited to configuration from userland... so
> it does not have any benefits.
We could turn this piece of code into a lib and make it usable by
both kernel/panic.c (similar to panic_blink) as well by
the ledtrig-morse.c.
> If special "panic blinking" mode is wanted -- I guess that would make
> sense.
>
> But
>
> a) trigger may not be right infrastructure for that; triggers need
> quite a lot kernel to be working, as they run in separate threads --
> panic blinking probably should be mdelay / brightness set / mdelay,
> and probably limited to LEDs that can be accessed without sleeping.
>
> b) we may want trigger to be used for something else (Caps lock? HDD
> activity?) when not panicked. Thus, again, trigger is not exactly
> suitable. (It might make sense to blink many/all LEDs simultaneously
> to make it super obvious to the user).
>
> Pavel
>
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2018-07-04 20:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 15:53 [PATCH v2] leds: ledtrig-morse: send out morse code Andreas Klinger
2018-07-03 18:43 ` Andy Shevchenko
2018-07-04 2:41 ` Willy Tarreau
2018-07-04 7:46 ` Geert Uytterhoeven
2018-07-04 16:25 ` Andy Shevchenko
2018-07-06 7:22 ` Geert Uytterhoeven
2018-07-04 6:53 ` Pavel Machek
2018-07-04 7:34 ` Willy Tarreau
2018-07-04 11:36 ` Greg KH
2018-07-04 18:19 ` Pavel Machek
2018-07-04 20:36 ` Jacek Anaszewski [this message]
2018-07-05 10:56 ` David Laight
2018-07-04 20:36 ` Jacek Anaszewski
2018-07-04 21:21 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a24e147-f2c7-9d82-0ce6-3238adf892b0@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=ak@it-klinger.de \
--cc=ben.whitten@gmail.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=pombredanne@nexb.com \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).