From: Juergen Gross <jgross@suse.com>
To: Nick Desaulniers <ndesaulniers@google.com>,
akpm@linux-foundation.org, hpa@zytor.com, mingo@redhat.com,
tglx@linutronix.de
Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
x86@kernel.org, virtualization@lists.linux-foundation.org,
astrachan@google.com, manojgupta@google.com,
ghackmann@google.com, sedat.dilek@gmail.com, tstellar@redhat.com,
keescook@google.com, yamada.masahiro@socionext.com,
michal.lkml@markovi.net, linux-kbuild@vger.kernel.org,
geert@linux-m68k.org, will.deacon@arm.com,
mawilcox@microsoft.com, arnd@arndb.de, rientjes@google.com,
acme@redhat.com, pombredanne@nexb.com, aryabinin@virtuozzo.com,
kstewart@linuxfoundation.org, boris.ostrovsky@oracle.com,
jan.kiszka@siemens.com, rostedt@goodmis.org,
kirill.shutemov@linux.intel.com, ard.biesheuvel@linaro.org,
akataria@vmware.com, brijesh.singh@amd.com,
caoj.fnst@cn.fujitsu.com, gregkh@linuxfoundation.org,
jarkko.sakkinen@linux.intel.com, jpoimboe@redhat.com,
mka@chromium.org, thomas.lendacky@amd.com, tweek@google.com,
mjg59@google.com, joe@perches.com,
andrea.parri@amarulasolutions.com
Subject: Re: [PATCH v5 0/3] extern inline native_save_fl for paravirt
Date: Tue, 19 Jun 2018 17:03:26 +0200 [thread overview]
Message-ID: <6a36db0d-e790-48d6-183a-263c355531b6@suse.com> (raw)
In-Reply-To: <20180613210518.113983-1-ndesaulniers@google.com>
On 13/06/18 23:05, Nick Desaulniers wrote:
> paravirt depends on a custom calling convention (callee saved), but
> expects this from a static inline function that it then forces to be
> outlined. This is problematic because different compilers or flags can
> then add a stack guard that violates the calling conventions.
>
> Uses extern inline with the out-of-line definition in assembly to
> prevent compilers from adding stack guards to the outlined version.
>
> Other parts of the codebase overwrite KBUILD_CFLAGS, which is *extremely
> problematic* for extern inline, as the sematics are completely the
> opposite depending on what C standard is used.
> http://blahg.josefsipek.net/?p=529
>
> Changes since v4:
> Take Arnd's and hpa's suggestions properly feature detect gnu_inline
> attribute to support gcc 4.1.
>
> Changes since v3:
> Take Joe's suggestion to hoist __inline__ and __inline out of
> conditional block.
>
> Changes since v2:
> Take hpa's _ASM_ARG patch into the set in order to simplify cross
> 32b/64b x86 assembly and rebase my final patch to use it. Apply
> Sedat's typo fix to commit message and sign off on it. Take Joe's
> suggestion to simplify __inline__ and __inline. Add Arnd to list of
> folks who made helpful suggestions.
>
> Changes since v1:
> Prefer gnu_inline function attribute instead of explicitly setting C
> standard compiler flag in problematic Makefiles. We should instead
> carefully evaluate if those Makefiles should be overwriting
> KBUILD_CFLAGS at all. Dropped the previous first two patches and added
> a new first patch.
>
> H. Peter Anvin (1):
> x86/asm: add _ASM_ARG* constants for argument registers to <asm/asm.h>
>
> Nick Desaulniers (2):
> compiler-gcc.h: add gnu_inline to all inline declarations
> x86: paravirt: make native_save_fl extern inline
>
> arch/x86/include/asm/asm.h | 59 +++++++++++++++++++++++++++++++++
> arch/x86/include/asm/irqflags.h | 2 +-
> arch/x86/kernel/Makefile | 1 +
> arch/x86/kernel/irqflags.S | 26 +++++++++++++++
> include/linux/compiler-gcc.h | 29 ++++++++++++----
> 5 files changed, 109 insertions(+), 8 deletions(-)
> create mode 100644 arch/x86/kernel/irqflags.S
>
For the series:
Acked-by: Juergen Gross <jgross@suse.com>
Juergen
prev parent reply other threads:[~2018-06-19 15:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 21:05 [PATCH v5 0/3] extern inline native_save_fl for paravirt Nick Desaulniers
2018-06-13 21:05 ` [PATCH v5 1/3] compiler-gcc.h: add gnu_inline to all inline declarations Nick Desaulniers
2018-06-13 21:05 ` [PATCH v5 2/3] x86/asm: add _ASM_ARG* constants for argument registers to <asm/asm.h> Nick Desaulniers
2018-06-14 20:47 ` H. Peter Anvin
2018-06-14 20:59 ` Nick Desaulniers
2018-06-15 0:17 ` H. Peter Anvin
2018-06-20 16:40 ` Nick Desaulniers
2018-06-21 12:28 ` Ingo Molnar
2018-06-15 4:04 ` Sedat Dilek
2018-06-13 21:05 ` [PATCH v5 3/3] x86: paravirt: make native_save_fl extern inline Nick Desaulniers
2018-06-14 13:20 ` [PATCH v5 0/3] extern inline native_save_fl for paravirt Sedat Dilek
2018-06-19 15:03 ` Juergen Gross [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a36db0d-e790-48d6-183a-263c355531b6@suse.com \
--to=jgross@suse.com \
--cc=acme@redhat.com \
--cc=akataria@vmware.com \
--cc=akpm@linux-foundation.org \
--cc=andrea.parri@amarulasolutions.com \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=aryabinin@virtuozzo.com \
--cc=astrachan@google.com \
--cc=boris.ostrovsky@oracle.com \
--cc=brijesh.singh@amd.com \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=geert@linux-m68k.org \
--cc=ghackmann@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=jan.kiszka@siemens.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=joe@perches.com \
--cc=jpoimboe@redhat.com \
--cc=keescook@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manojgupta@google.com \
--cc=mawilcox@microsoft.com \
--cc=michal.lkml@markovi.net \
--cc=mingo@redhat.com \
--cc=mjg59@google.com \
--cc=mka@chromium.org \
--cc=ndesaulniers@google.com \
--cc=pombredanne@nexb.com \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=sedat.dilek@gmail.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=tstellar@redhat.com \
--cc=tweek@google.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).